Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove nand0p as maintainer #122994

Merged

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 14, 2021

Motivation for this change

While looking at the sphinx package (#122189) I noticed it was heavily
undermaintained, which is when we noticed nand0p has been inactive for
roughly 18 months. It is therefore prudent to assume they will not be
maintaining their packages, modules and tests.

  • Their last contribution to nixpkgs was in 2019/12
  • On 2021/05/08 I wrote them an email to the address listed in the
    maintainer-list, which they didn't reply to.

E-Mail contents:
https://gist.github.com/mweinelt/4c2ffbb8214e58a7630b3da68e8c45a0

Open questions:

  • How long do we want to wait for them to reply?
  • Should we remove the maintainer handle as well?

What was done:

find pkgs -iname "*.nix" -exec sed -i 's/nand0p //' {} \\;
find nixos -iname "*.nix" -exec sed -i 's/nand0p //' {} \\;

cc @dotlambda @vcunat @nand0p

Things done

pkgs/tools/graphics/flam3/default.nix Outdated Show resolved Hide resolved
@dotlambda
Copy link
Member

  • How long do we want to wait for them to reply?

Why can always revert, so I see no reason to wait too long.

  • Should we remove the maintainer handle as well?

It's only fair to @nand0p to do so, as his personal data shouldn't be lingering around for no reason.

@mweinelt mweinelt force-pushed the remove-inactive-maintainer/nand0p branch from 8103735 to c261395 Compare May 16, 2021 14:20
@mweinelt
Copy link
Member Author

Done

@SuperSandro2000
Copy link
Member

@mweinelt please fix the merge conflict.

While looking at the sphinx package I noticed it was heavily
undermaintained, which is when we noticed nand0p has been inactive for
roughly 18 months. It is therefore prudent to assume they will not be
maintaining their packages, modules and tests.

- Their last contribution to nixpkgs was in 2019/12
- On 2021/05/08 I wrote them an email to the address listed in the
  maintainer-list, which they didn't reply to.
@mweinelt mweinelt force-pushed the remove-inactive-maintainer/nand0p branch from c261395 to 7bd65d5 Compare May 16, 2021 23:50
@mweinelt
Copy link
Member Author

Done

@SuperSandro2000 SuperSandro2000 merged commit 622c2c2 into NixOS:master May 17, 2021
@mweinelt mweinelt deleted the remove-inactive-maintainer/nand0p branch May 17, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants