Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/postgresqlBackup: allow defining multiple times to start at #123006

Merged
merged 1 commit into from May 18, 2021
Merged

nixos/postgresqlBackup: allow defining multiple times to start at #123006

merged 1 commit into from May 18, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

Allow setting one, multiple, or no startAt times.

#111427 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt mentioned this pull request May 14, 2021
Closed
@mweinelt
nixos/postgresqlBackup: allow defining multiple times to start at
21746a7 
Or … none! Because forcing a string always results in an OnCalender=
setting, but an empty string leads to an empty value.

>  postgresqlBackup-hass.timer: Timer unit lacks value setting. Refusing.

or

> postgresqlBackup-miniflux.timer: Cannot add dependency job, ignoring: Unit postgresqlBackup-miniflux.timer has a bad unit file setting.

I require the postgresqlBackup in my borgbackup unit, so I don't
strictly need the timer and could previously set it to an empty list.
@mweinelt mweinelt added this to the 21.05 milestone May 15, 2021
@mweinelt mweinelt merged commit a8f71f0 into NixOS:master May 18, 2021
@mweinelt mweinelt deleted the postgresqlbackup-startat branch May 18, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz approved these changes

@dotlambda dotlambda dotlambda approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @talyz @dotlambda