Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tts: 0.0.12 -> 0.0.13 #123016

Merged
merged 1 commit into from May 16, 2021
Merged

tts: 0.0.12 -> 0.0.13 #123016

merged 1 commit into from May 16, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

https://github.com/coqui-ai/TTS/releases/tag/v0.0.13

❯ ./result/bin/tts --text "To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do\!"
 > Downloading model to /home/hexa/.local/share/tts/tts_models--en--ljspeech--tacotron2-DDC
 > Downloading model to /home/hexa/.local/share/tts/vocoder_models--en--ljspeech--hifigan_v2
 > Using model: Tacotron2
 > Generator Model: hifigan_generator
Removing weight norm...
 > Text: To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do!
 > Text splitted to sentences.
['To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates.', 'Just leave a comment describing what you have tested in the relevant package/service.', 'Reviewing helps to reduce the average time-to-merge for everyone.', 'Thanks a lot if you do!']
 > Processing time: 9.314172506332397
 > Real-time factor: 0.4426849905259117
 > Saving output to tts_output.wav

https://shells.darmstadt.ccc.de/~hexa/tts-0.0.13.wav

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member

davidak commented May 16, 2021

Result of nixpkgs-review pr 123016 run on x86_64-linux 1

1 package built:
  • tts

sed -i -e '/isor/d' requirements.txt
sed -i -e '/pylint/d' requirements.txt
sed -i -e '/cardboardlint/d' requirements.txt setup.py
sed -i -e 's!librosa==[^"]*!librosa!' requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this get upstreamed?

e.g. they say librosa==0.7.2 is needed but we have 0.8.0 and it still works

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is we don't really want this to be pinned in any way as it will just cause problems in future.

Copy link
Member Author

@mweinelt mweinelt May 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They could set lower bounds, but I don't think they will be receptive to our needs tbh, because it will cause them issues when new versions break tts.

@davidak
Copy link
Member

davidak commented May 16, 2021

I tested also the 2 new models. Here are examples: tts_output.zip

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

Builds, works

@davidak davidak merged commit 8d9ae3d into NixOS:master May 16, 2021
@mweinelt mweinelt deleted the tts branch May 16, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants