New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tts: 0.0.12 -> 0.0.13 #123016
tts: 0.0.12 -> 0.0.13 #123016
Conversation
Result of 1 package built:
|
sed -i -e '/isor/d' requirements.txt | ||
sed -i -e '/pylint/d' requirements.txt | ||
sed -i -e '/cardboardlint/d' requirements.txt setup.py | ||
sed -i -e 's!librosa==[^"]*!librosa!' requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this get upstreamed?
e.g. they say librosa==0.7.2
is needed but we have 0.8.0
and it still works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is we don't really want this to be pinned in any way as it will just cause problems in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They could set lower bounds, but I don't think they will be receptive to our needs tbh, because it will cause them issues when new versions break tts.
I tested also the 2 new models. Here are examples: tts_output.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Builds, works
Motivation for this change
https://github.com/coqui-ai/TTS/releases/tag/v0.0.13
https://shells.darmstadt.ccc.de/~hexa/tts-0.0.13.wav
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)