home-assistant: 2021.5.3 -> 2021.5.4 #123056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 1 package failed to build:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 1 package failed to build:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
|
Result of |
|
How weird, it says nothing to be built for me. |
|
Result of 1 package built:
|
fabaff
approved these changes
May 15, 2021
|
There seems to have been a failure on aarch64 Can somebody confirm it's a transient failure? |
|
Result of 1 package failed to build:
I have seen the |
|
Let's see if we can get some more details on those flaky tests using |
|
@fabaff @happysalada I need someone to reproduce the issue with |
This comment has been minimized.
This comment has been minimized.
|
The mobile app issue reproduced on my RPi4 (aarch64-linux). ____________________ test_webhook_handle_get_config[pyloop] ____________________
[gw1] linux -- Python 3.8.9 /nix/store/7i305r9i4rsb1hmqwkdmphjf430niq3l-python3-3.8.9/bin/python3.8
hass = <homeassistant.core.HomeAssistant object at 0xffffc9ec6fa0>
create_registrations = ({'cloudhook_url': None, 'remote_ui_url': None, 'secret': '00c930ab9c1c724ab514ac14ac40a410ad7bf089b6f23cef4e6e9b27833...emote_ui_url': None, 'secret': None, 'webhook_id': 'd62002d044f9307156434143a8ee16587c591093f500721ef3fe0e3c823b82ba'})
webhook_client = <aiohttp.test_utils.TestClient object at 0xffffc9c874f0>
async def test_webhook_handle_get_config(hass, create_registrations, webhook_client):
"""Test that we can get config properly."""
resp = await webhook_client.post(
"/api/webhook/{}".format(create_registrations[1]["webhook_id"]),
json={"type": "get_config"},
)
assert resp.status == 200
json = await resp.json()
if "components" in json:
json["components"] = set(json["components"])
if "allowlist_external_dirs" in json:
json["allowlist_external_dirs"] = set(json["allowlist_external_dirs"])
hass_config = hass.config.as_dict()
expected_dict = {
"latitude": hass_config["latitude"],
"longitude": hass_config["longitude"],
"elevation": hass_config["elevation"],
"unit_system": hass_config["unit_system"],
"location_name": hass_config["location_name"],
"time_zone": hass_config["time_zone"],
"components": hass_config["components"],
"version": hass_config["version"],
"theme_color": "#03A9F4", # Default frontend theme color
}
> assert expected_dict == json
E AssertionError: assert {'components'...st home', ...} == {'components'...st home', ...}
E Omitting 8 identical items, use -vv to show
E Differing items:
E {'theme_color': '#03A9F4'} != {'theme_color': 'blue'}
E Use -v to get the full diff |
|
Same for me with aarch64-linux (Raspberry Pi 4). I guess that I would see the same output if I could scroll back more... [...]
=========================== short test summary info ============================
FAILED tests/components/mobile_app/test_webhook.py::test_webhook_handle_get_config[pyloop]
===== 1 failed, 8959 passed, 5 skipped, 465 warnings in 5707.48s (1:35:07) =====
builder for '/nix/store/g2vmjkhjsrzj0dzp2586vldfhdvgidwy-homeassistant-2021.5.4.drv' failed with exit code 1
error: build of '/nix/store/g2vmjkhjsrzj0dzp2586vldfhdvgidwy-homeassistant-2021.5.4.drv' failed |
|
You could scroll back more, if you didn't use nixpkgs-review to build, but instead just used |
|
I was playing around with the terminals in VScodium. Their implementation is somehow limited in the amount of lines you can scroll back by default (unlike gnome-terminal which is set to 10 k lines in NixOS). After a reboot I can't reproduce the failure (around |
____________________ test_webhook_handle_get_config[pyloop] ____________________
[gw18] linux -- Python 3.8.9 /nix/store/q6gfck5czr67090pwm53xrdyhpg6bx67-python3-3.8.9/bin/python3.8
hass = <homeassistant.core.HomeAssistant object at 0x7ffe4e71f370>
create_registrations = ({'cloudhook_url': None, 'remote_ui_url': None, 'secret': 'ed8ac650f2b5865733d2cea4ad1b6b02bcfbdcc3e527524bc1c457d5c6f...emote_ui_url': None, 'secret': None, 'webhook_id': '558fde83113d48024a427ccf004e2d2bdf7c56646c6a5a953566c272d51f1bfc'})
webhook_client = <aiohttp.test_utils.TestClient object at 0x7ffe4e640ca0>
async def test_webhook_handle_get_config(hass, create_registrations, webhook_client):
"""Test that we can get config properly."""
resp = await webhook_client.post(
"/api/webhook/{}".format(create_registrations[1]["webhook_id"]),
json={"type": "get_config"},
)
assert resp.status == 200
json = await resp.json()
if "components" in json:
json["components"] = set(json["components"])
if "allowlist_external_dirs" in json:
json["allowlist_external_dirs"] = set(json["allowlist_external_dirs"])
hass_config = hass.config.as_dict()
expected_dict = {
"latitude": hass_config["latitude"],
"longitude": hass_config["longitude"],
"elevation": hass_config["elevation"],
"unit_system": hass_config["unit_system"],
"location_name": hass_config["location_name"],
"time_zone": hass_config["time_zone"],
"components": hass_config["components"],
"version": hass_config["version"],
"theme_color": "#03A9F4", # Default frontend theme color
}
> assert expected_dict == json
E AssertionError: assert {'components'...st home', ...} == {'components'...st home', ...}
E Omitting 8 identical items, use -vv to show
E Differing items:
E {'theme_color': '#03A9F4'} != {'theme_color': 'blue'}
E Use -v to get the full diff
tests/components/mobile_app/test_webhook.py:231: AssertionError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/home-assistant/core/releases/tag/2021.5.4
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)