Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taglib-extras: add missing dependency zlib #123071

Merged
merged 1 commit into from
May 15, 2021

Conversation

emmanuelrosa
Copy link
Contributor

@emmanuelrosa emmanuelrosa commented May 15, 2021

This change adds zlib as a dependency to address the error:

/nix/store/5xyjd2qiily84lcv2w2grmwsb8r1hqpr-binutils-2.35.1/bin/ld: cannot find -lz
collect2: error: ld returned 1 exit status
make[2]: *** [taglib-extras/CMakeFiles/tag-extras.dir/build.make:208:
taglib-extras/libtag-extras.so.1.0.0] Error 1
make[1]: *** [CMakeFiles/Makefile2:154:
taglib-extras/CMakeFiles/tag-extras.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
builder for
'/nix/store/w1ac3b6v5yfblbnqzyxa6y4738frlmvr-taglib-extras-1.0.1.drv'
failed with exit code 2

This allows amarok to build. See https://hydra.nixos.org/build/142979429

ZHF: #122042

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change adds zlib as a dependency to address the error:

```
/nix/store/5xyjd2qiily84lcv2w2grmwsb8r1hqpr-binutils-2.35.1/bin/ld: cannot find -lz
collect2: error: ld returned 1 exit status
make[2]: *** [taglib-extras/CMakeFiles/tag-extras.dir/build.make:208:
taglib-extras/libtag-extras.so.1.0.0] Error 1
make[1]: *** [CMakeFiles/Makefile2:154:
taglib-extras/CMakeFiles/tag-extras.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
builder for
'/nix/store/w1ac3b6v5yfblbnqzyxa6y4738frlmvr-taglib-extras-1.0.1.drv'
failed with exit code 2
```

ZHF: NixOS#122042
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 15, 2021

Result of nixpkgs-review pr 123071 at 281c541 run on aarch64-linux 1

2 packages built successfully:
  • cantata
  • taglib_extras

Result of nixpkgs-review pr 123071 at 281c541 run on x86_64-linux 1

3 packages built successfully:
  • amarok (amarok-kf5)
  • cantata
  • taglib_extras
2 suggestions:
  • warning: unclear-gpl

    lgpl2 is a deprecated license, please check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.

    Near pkgs/development/libraries/taglib-extras/default.nix:20:5:

       |
    20 |     license = licenses.lgpl2;
       |     ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/taglib-extras/default.nix:17:3:

       |
    17 |   meta = with lib; {
       |   ^
    

@fabaff
Copy link
Member

fabaff commented May 15, 2021

Result of nixpkgs-review pr 123071 run on x86_64-linux 1

3 packages built:
  • amarok
  • cantata
  • taglib_extras

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 8599a6c into NixOS:master May 15, 2021
@emmanuelrosa emmanuelrosa deleted the zhf-taglib-extras branch May 15, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants