Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop thunderbird{,-bin} 68 #123129

Merged
merged 4 commits into from May 16, 2021
Merged

drop thunderbird{,-bin} 68 #123129

merged 4 commits into from May 16, 2021

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented May 15, 2021

Motivation for this change

I personally don't use Thunderbird much, but I'd rather not have an EOL version in nixpkgs, if there aren't any really good reasons to keep it around.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 marked this pull request as ready for review May 15, 2021 16:07
@ajs124 ajs124 requested review from vcunat and taku0 May 15, 2021 16:07
vcunat
vcunat approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason to keep these.

@vcunat vcunat added this to the 21.05 milestone May 15, 2021
@taku0
Copy link
Contributor

taku0 commented May 16, 2021

@mweinelt @xfix
Did you succeed to migrate to OpenPGP?

@vcunat
Copy link
Member

vcunat commented May 16, 2021

I did, though I don't use it very often.

taku0
taku0 approved these changes May 16, 2021
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@teto
Copy link
Member

teto commented May 16, 2021

seems like we have a consensus :)

@teto teto merged commit 3399b0e into NixOS:master May 16, 2021
@ajs124 ajs124 deleted the drop/thunderbird-68 branch May 16, 2021 14:33
@KamilaBorowska
Copy link
Member

KamilaBorowska commented May 16, 2021 •
edited

@mweinelt @xfix
Did you succeed to migrate to OpenPGP?

Yeah, no issues here, migrated when GPG was supported by Thunderbird 78.

@mweinelt
Copy link
Member

Not using Thunderbird anymore, neomutt all the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ajs124 @taku0 @vcunat @teto @KamilaBorowska @mweinelt