Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.growattserver: init at 1.0.1 #123179

Closed
wants to merge 3 commits into from

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 15, 2021

Motivation for this change

Python package to retrieve information from Growatt units

https://github.com/indykoning/PyPi_GrowattServer

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 16, 2021

Result of nixpkgs-review pr 123179 at 9ca996c run on aarch64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.growattserver
  • python39Packages.growattserver

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 123179 at 9ca996c run on x86_64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.growattserver
  • python39Packages.growattserver

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@mweinelt mweinelt moved this from To do to Waiting in Home Assistant May 17, 2021
Home Assistant automation moved this from On Hold to Reviewed May 23, 2021
@SuperSandro2000
Copy link
Member

@fabaff please resolve the merge conflict.

@mweinelt
Copy link
Member

mweinelt commented Jun 2, 2021

I have cherry-picked this change into my staging tree, thank you!

@mweinelt mweinelt closed this Jun 2, 2021
Home Assistant automation moved this from Reviewed to Done Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants