Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/opensmtpd: add useACMEHosts option #123261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m1cr0man
Copy link
Contributor

Motivation for this change

Closes #101389

This allows the user to configure any number of certificates
to be loaded into opensmtpd on startup. A new service was added
to restart opensmtpd when certificates are updated.

This is the first time we're using LoadCredential. I have not found a way
to support hot reload with this method yet. It copies the cert files to a
special folder on start, and doesn't repeat the process if the files change
or if the service is reloaded.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This allows the user to configure any number of certificates
to be loaded into opensmtpd on startup. A new service was added
to restart opensmtpd when certificates are updated.
@stale
Copy link

stale bot commented Nov 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixos/acme: 20.03 -> 20.09 regression with opensmtpd
2 participants