New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer pname
and version
in mkDerivation
s instead of name
#123438
Conversation
Result of 7 packages marked as broken and skipped:
1 package failed to build:48 packages skipped due to time constraints:
73 packages built successfully:
5 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 23 packages marked as broken and skipped:
1 package failed to build:257 packages skipped due to time constraints:
161 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some suggestions, up to you to decide if you want to implement those.
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Motivation for this change
In pursuit of #103997, I present this PR which AFAICT gets rid of most if not all of the remaining usages of
name
inmkDerivations
. I did a search throughpkgs/
, and fixed each manually.I only tackled
mkDerivations
with "literal"name
usage. Functions that generatemkDerivation
s withname
are another beast. Also batch files for things like node/yarn/etc we're skipped. Instances ofmkDerivation
outside ofpkgs/
were not addressed.Logs for
nixpkgs-review wip
can be found here: https://gist.github.com/samuela/a71de800aef3e31a2e0e116b10ff0aa5. There are three failures, but they seem unrelated to the changes in this PR. Perhaps these should packages should be marked broken?Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)