Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steam: add json-glib to fhsenv #123453

Merged
merged 1 commit into from May 18, 2021
Merged

steam: add json-glib to fhsenv #123453

merged 1 commit into from May 18, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

Fixes the Paradox Launcher for Stellaris.

Fixes: #123447

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes the Paradox Launcher for Stellaris.

Fixes: NixOS#123447
@mweinelt mweinelt changed the title steam: add json-glib to to fhsenv steam: add json-glib to fhsenv May 18, 2021
@jonringer
Copy link
Contributor

I don't have stellaris installed right now, but the PR looks good, and steam builds fine.

@jonringer jonringer merged commit 707234b into NixOS:master May 18, 2021
@mweinelt mweinelt deleted the steam branch May 18, 2021 10:28
@jbalme
Copy link
Contributor

jbalme commented May 24, 2021

I can confirm it works for me, thanks.

@jonringer
Copy link
Contributor

Ironically, CK3 started to show this as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

steam: paradox launcher needs json-glib (transitive)
3 participants