home-assistant: enable alot more component tests #123456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You guessed my password! |
mweinelt
force-pushed
the
home-assistant-tests
branch
from
f525eb3
to
49ac3d9
Compare
The following test failure occurs with 4.2.1, due to `network` not being allowed to be None after pylast/pylast@6fe9aa6. _________________________ test_update_playing[pyloop] __________________________ [gw20] linux -- Python 3.8.9 /nix/store/hq6mrm0pc6xn6j8y6lm4qcgg9rwmqd8q-python3-3.8.9/bin/python3.8 hass = <homeassistant.core.HomeAssistant object at 0x7ffdcba15700> lastfm_network = <MagicMock name='LastFMNetwork' id='140728019800752'> async def test_update_playing(hass, lastfm_network): """Test update when song playing.""" lastfm_network.return_value.get_user.return_value = MockUser( > Track("artist", "title", None) ) hass = <homeassistant.core.HomeAssistant object at 0x7ffdcba15700> lastfm_network = <MagicMock name='LastFMNetwork' id='140728019800752'> tests/components/lastfm/test_sensor.py:70: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ /nix/store/f0ci60zk59rz5767l9lfy7q767zna6j5-python3.8-pylast-4.2.1/lib/python3.8/site-packages/pylast/__init__.py:2095: in __init__ super().__init__(artist, title, network, "track", username, info) __class__ = <class 'pylast.Track'> artist = 'artist' info = None network = None self = pylast.Track('artist', 'title', None) title = 'title' username = None _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = pylast.Track('artist', 'title', None), artist = 'artist', title = 'title' network = None, ws_prefix = 'track', username = None, info = {} def __init__(self, artist, title, network, ws_prefix, username=None, info=None): """ Create an opus instance. # Parameters: * artist: An artist name or an Artist object. * title: The album or track title. * ws_prefix: 'album' or 'track' """ if info is None: info = {} super().__init__(network=network, ws_prefix=ws_prefix) if isinstance(artist, Artist): self.artist = artist else: self.artist = Artist(artist, self.network) self.title = title self.username = ( > username if username else network.username ) # Default to current user E AttributeError: 'NoneType' object has no attribute 'username' __class__ = <class 'pylast._Opus'> artist = 'artist' info = {} network = None self = pylast.Track('artist', 'title', None) title = 'title' username = None ws_prefix = 'track' /nix/store/f0ci60zk59rz5767l9lfy7q767zna6j5-python3.8-pylast-4.2.1/lib/python3.8/site-packages/pylast/__init__.py:1520: AttributeError
mweinelt
force-pushed
the
home-assistant-tests
branch
from
49ac3d9
to
27cc2b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enable tests for all components we have packaged up, when they exist.
Update
pyflumeto 0.7.0 to get rid ofpyjwt<2.0pin.Update component-packages to include
pygattdependency.Since the majority of tests that aren't working are network related (Trying to send out packets, trying to join multicast groups, ...) I'm going to propose a network marker on those tests upstream.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)