Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.ati_drivers_x11: remove #123602

Merged
merged 1 commit into from May 19, 2021
Merged

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented May 19, 2021

Motivation for this change

ATI driver is no longer supported for kernels > 4.1. We only carry kernels >= 4.4.

Doing house cleaning before post-branch-off "mark all failing builds as broken" event.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Driver is no longer supported for kernels >= 4.1.
@jonringer
Copy link
Contributor Author

16 packages removed:
ati-drivers (†15.12-4.14.232) ati-drivers (†15.12-4.19.190) ati-drivers (†15.12-4.4.268) ati-drivers (†15.12-4.9.268) ati-drivers (†15.12-5.10.37) ati-drivers (†15.12-5.10.37) ati-drivers (†15.12-5.10.37) ati-drivers (†15.12-5.11.16) ati-drivers (†15.12-5.11.16) ati-drivers (†15.12-5.11.21) ati-drivers (†15.12-5.11.21) ati-drivers (†15.12-5.11.21) ati-drivers (†15.12-5.11.21) ati-drivers (†15.12-5.12.4) ati-drivers (†15.12-5.4.119) ati-drivers (†15.12-5.9.0-2020.11.20)

@mweinelt mweinelt merged commit 29c7d3c into NixOS:master May 19, 2021
@jonringer jonringer deleted the mark-ati-broken branch May 19, 2021 02:37
@Ma27
Copy link
Member

Ma27 commented May 23, 2021

Evaluation seems to fail here when trying to build a system with documentation.nixos.includeAllModules = true;. Currently investigating why.

EDIT: nvm, it's apparently related to another module I wrote, sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants