Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.rtl8821ce: mark broken for aarch64 #123651

Merged
merged 1 commit into from May 19, 2021
Merged

linuxPackages.rtl8821ce: mark broken for aarch64 #123651

merged 1 commit into from May 19, 2021

Conversation

moni-dz
Copy link
Contributor

@moni-dz moni-dz commented May 19, 2021

Motivation for this change

ZHF: #122042
https://hydra.nixos.org/eval/1671194?filter=rtl8821ce&compare=1671097&full=1#tabs-still-fail

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed May 19, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/os-specific/linux/rtl8821ce/default.nix Outdated Show resolved Hide resolved
@moni-dz @jonringer
linuxPackages.rtl8821ce: mark broken for aarch64
c126516 
Co-authored-by: Jonathan Ringer <jonringer@users.noreply.github.com>
@moni-dz moni-dz requested a review from jonringer May 19, 2021 16:59
jonringer
jonringer approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonringer jonringer merged commit 5e52c37 into NixOS:master May 19, 2021
@moni-dz moni-dz deleted the rtl8821ce branch May 19, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moni-dz @jonringer