Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: add openssl to buildInputs #123693

Merged
merged 1 commit into from May 20, 2021
Merged

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented May 19, 2021

Motivation for this change

It should be included regardless of whether tests are run or not, and
overriding the package to disable tests would break this package up
until this change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Deployed own matrix server with this change
  • Fits CONTRIBUTING.md.

It should be included regardless of whether tests are run or not, and
overriding the package to disable tests would break this package up
until this change.
@lheckemann lheckemann changed the title matrix-synapse: move openssl to buildInputs matrix-synapse: add openssl to buildInputs May 19, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 19, 2021

Result of nixpkgs-review pr 123693 at f26200f run on x86_64-linux 1

2 packages built successfully:
  • matrix-synapse
  • tests.trivial

Result of nixpkgs-review pr 123693 at f26200f run on aarch64-linux 1

1 package built successfully:
  • matrix-synapse

@Ma27 Ma27 merged commit edf4552 into NixOS:master May 20, 2021
@Ma27 Ma27 deleted the matrix-openssl branch May 20, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants