Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.envoy-reader: init at 0.19.0 #123727

Merged
merged 3 commits into from May 23, 2021
Merged

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 19, 2021

Motivation for this change

Python module to read from Enphase Envoy units

https://github.com/jesserizzo/envoy_reader

This is a Home Assistant depedency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Traceback (most recent call last):
  File "/nix/store/pp3aa69gq6g21h6zbmzvb5525ybdq1gf-python3.8-ha-ffmpeg-3.0.2/lib/python3.8/site-packages/haffmpeg/core.py", line 136, in open
    self._proc = await self._loop.run_in_executor(None, proc_func)
  File "/nix/store/71kh64r972bfm9n4jfzvjk2mrmg8zlvl-python3-3.8.9/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/nix/store/71kh64r972bfm9n4jfzvjk2mrmg8zlvl-python3-3.8.9/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/71kh64r972bfm9n4jfzvjk2mrmg8zlvl-python3-3.8.9/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ffmpeg'

@fabaff
Copy link
Member Author

fabaff commented May 19, 2021

Result of nixpkgs-review pr 123727 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.envoy-reader
  • python39Packages.envoy-reader

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123727 at a766776 run on aarch64-linux 1

1 package failed to build:
  • home-assistant
2 packages built successfully:
  • python38Packages.envoy-reader
  • python39Packages.envoy-reader

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@dotlambda
Copy link
Member

Traceback (most recent call last):
  File "/nix/store/pp3aa69gq6g21h6zbmzvb5525ybdq1gf-python3.8-ha-ffmpeg-3.0.2/lib/python3.8/site-packages/haffmpeg/core.py", line 136, in open
    self._proc = await self._loop.run_in_executor(None, proc_func)
  File "/nix/store/71kh64r972bfm9n4jfzvjk2mrmg8zlvl-python3-3.8.9/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/nix/store/71kh64r972bfm9n4jfzvjk2mrmg8zlvl-python3-3.8.9/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/71kh64r972bfm9n4jfzvjk2mrmg8zlvl-python3-3.8.9/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ffmpeg'

@mweinelt Did that happen in your deployment of Home Assistant? You should set https://www.home-assistant.io/integrations/ffmpeg#ffmpeg_bin.

@mweinelt
Copy link
Member

mweinelt commented May 20, 2021

Traceback (most recent call last):
  File "/nix/store/pp3aa69gq6g21h6zbmzvb5525ybdq1gf-python3.8-ha-ffmpeg-3.0.2/lib/python3.8/site-packages/haffmpeg/core.py", line 136, in open
    self._proc = await self._loop.run_in_executor(None, proc_func)
  File "/nix/store/71kh64r972bfm9n4jfzvjk2mrmg8zlvl-python3-3.8.9/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/nix/store/71kh64r972bfm9n4jfzvjk2mrmg8zlvl-python3-3.8.9/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/71kh64r972bfm9n4jfzvjk2mrmg8zlvl-python3-3.8.9/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ffmpeg'

@mweinelt Did that happen in your deployment of Home Assistant? You should set https://www.home-assistant.io/integrations/ffmpeg#ffmpeg_bin.

Pulled from ofBorg logs.

@dotlambda
Copy link
Member

It seems unrelated to this change, but I guess ffmpeg should be in checkInputs unless we wanna patch https://github.com/home-assistant/core/blob/922eec09098e0462b64bea91210a674512b8530a/homeassistant/components/ffmpeg/__init__.py#L42. That would increase the closure size though.

@lukegb
Copy link
Contributor

lukegb commented May 23, 2021

@ofborg build python3Packages.envoy-reader

@lukegb lukegb merged commit ee0e711 into NixOS:master May 23, 2021
Home Assistant automation moved this from To do to Done May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants