Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.hdbscan: disable flaky test #123736

Merged
merged 1 commit into from May 20, 2021
Merged

python3Packages.hdbscan: disable flaky test #123736

merged 1 commit into from May 20, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 19, 2021 •
edited

Motivation for this change

This test is acknowledged to be flaky: scikit-learn-contrib/hdbscan#420

ZHF #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented May 19, 2021 •
edited

Ugh hold on looks like I need to add a couple more to that list :(

edit: Done.

@risicle risicle force-pushed the ris-hdbscan-disable-flaky-test branch from 8d4dbee to 6241560 Compare May 19, 2021 22:10
@ofborg ofborg bot requested a review from ixxie May 19, 2021 22:12
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 20, 2021 •
edited

Result of nixpkgs-review pr 123736 at 6241560 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.hdbscan
  • python39Packages.hdbscan

Result of nixpkgs-review pr 123736 at 6241560 run on x86_64-linux 1

3 packages built successfully:
  • python38Packages.hdbscan
  • python39Packages.hdbscan
  • tests.trivial

@mweinelt mweinelt merged commit a9f4acc into NixOS:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@ixxie ixxie Awaiting requested review from ixxie

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @r-rmcgibbo @mweinelt