Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.rtl88x2bu: switch to more maintained fork #123754

Merged
merged 1 commit into from May 20, 2021

Conversation

moni-dz
Copy link
Contributor

@moni-dz moni-dz commented May 20, 2021

Motivation for this change

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@moni-dz moni-dz changed the title rtl88x2bu: 2021-01-21 -> 2021-04-16, add patch for 5.12 kernels linuxPackages.rtl88x2bu: 2021-01-21 -> 2021-04-16, add patch for 5.12 kernels May 20, 2021
@moni-dz
Copy link
Contributor Author

moni-dz commented May 20, 2021

@ofborg build linuxPackages_5_12.rtl88x2bu

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123754 at a1540702 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • linuxPackages-libre.rtl88x2bu
  • linuxPackages_hardkernel_4_14.rtl88x2bu
  • linuxPackages_hardkernel_latest.rtl88x2bu
  • linuxPackages_latest-libre.rtl88x2bu
1 package skipped due to time constraints:
  • tests.trivial
14 packages built successfully:
  • linuxPackages.rtl88x2bu (linuxPackages_5_10.rtl88x2bu)
  • linuxPackages_4_14.rtl88x2bu
  • linuxPackages_4_19.rtl88x2bu
  • linuxPackages_4_4.rtl88x2bu
  • linuxPackages_4_9.rtl88x2bu
  • linuxPackages_5_11.rtl88x2bu (linuxPackages_latest.rtl88x2bu)
  • linuxPackages_5_12.rtl88x2bu
  • linuxPackages_5_4.rtl88x2bu
  • linuxPackages_hardened.rtl88x2bu
  • linuxPackages_latest_hardened.rtl88x2bu
  • linuxPackages_lqx.rtl88x2bu
  • linuxPackages_testing_bcachefs.rtl88x2bu
  • linuxPackages_xanmod.rtl88x2bu
  • linuxPackages_zen.rtl88x2bu

@moni-dz moni-dz marked this pull request as draft May 20, 2021 06:27
@moni-dz moni-dz changed the title linuxPackages.rtl88x2bu: 2021-01-21 -> 2021-04-16, add patch for 5.12 kernels linuxPackages.rtl88x2bu: switch to more maintained fork May 20, 2021
@moni-dz moni-dz marked this pull request as ready for review May 20, 2021 06:35
@moni-dz
Copy link
Contributor Author

moni-dz commented May 20, 2021

@ofborg build linuxPackages_5_12.rtl88x2bu

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 123754 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • linuxPackages-libre.rtl88x2bu
  • linuxPackages_hardkernel_4_14.rtl88x2bu
  • linuxPackages_hardkernel_latest.rtl88x2bu
  • linuxPackages_latest-libre.rtl88x2bu
15 packages built:
  • linuxPackages.rtl88x2bu (linuxPackages_5_10.rtl88x2bu)
  • linuxPackages_4_14.rtl88x2bu
  • linuxPackages_4_19.rtl88x2bu
  • linuxPackages_4_4.rtl88x2bu
  • linuxPackages_4_9.rtl88x2bu
  • linuxPackages_5_11.rtl88x2bu (linuxPackages_latest.rtl88x2bu)
  • linuxPackages_5_12.rtl88x2bu
  • linuxPackages_5_4.rtl88x2bu
  • linuxPackages_hardened.rtl88x2bu
  • linuxPackages_latest_hardened.rtl88x2bu
  • linuxPackages_lqx.rtl88x2bu
  • linuxPackages_testing_bcachefs.rtl88x2bu
  • linuxPackages_xanmod.rtl88x2bu
  • linuxPackages_zen.rtl88x2bu
  • tests.trivial

@jonringer jonringer merged commit c50b59f into NixOS:master May 20, 2021
@moni-dz moni-dz deleted the rtl88x2bu branch May 20, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants