Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Erlang support in Nix #12409

Merged
merged 13 commits into from
Jan 16, 2016
Merged

Improvements for Erlang support in Nix #12409

merged 13 commits into from
Jan 16, 2016

Conversation

ericbmerritt
Copy link
Contributor

No description provided.

ericbmerritt and others added 13 commits January 14, 2016 14:34
This allows us to have a callPackages that includes erlang packages
This changes build-hex.nix so that the buildHex and related functions
work correctly in a nix-shell.
This commit moves all the hex based packages to a single namespace. It
also moves all the packages to a single file.  This is in preparation
for the move to a system to generate the hex packages from the hex
package store.
The buildErlang function is broken and and leads Engineers down a wrong
path. For vanilla erlang that doesn't user rebar3, its better to simply
use `stdenv.mkDerivation` along with a set setupHook then the existing
functionality.
Building Hex packages is a superset of building with rebar3. There is no
need to force folks that use rebar3 but not hex to build with hex. This
commit seperates the rebar3 specific bits and the hex specific bits into
seperate functions that can be used independently.
This commit adds 187 packages from Hex.pm and documents 100 more that
could not be imported for various reasons. The packages where generated
by hex2nix.
This commit adds some very minimial documentation to the Nix
manual. Hopefully, its enough to get someone started and serve as a
first footstep for future documentation writers
This commit allows the installPhase of buildRebar3 to be overridden by
the user.
Move registrySnapshot to the erlang-nix github organization
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @gleber to be a potential reviewer

@domenkozar
Copy link
Member

Nice. I'd be interested to know how erlang discovers packages installed with nix-env

@gleber
Copy link
Contributor

gleber commented Jan 16, 2016

That's a part of #11748

@peti @sjmackenzie Please take a look.

@gleber
Copy link
Contributor

gleber commented Jan 16, 2016

@domenkozar Current it does not support this. At the moment it supports only nix-shell. The way it could work is to extend ERL_LIBS env variable when a package is installed with nix-env, but I do not know yet how to do it. If you know how to do it, I'd love to know :)

peti added a commit that referenced this pull request Jan 16, 2016
Improvements for Erlang support in Nix
@peti peti merged commit 7824b8c into NixOS:master Jan 16, 2016
@ericbmerritt
Copy link
Contributor Author

Let me second Gleb there. We would love to support it. No clue how at the moment.

Sent from Outlook Mobilehttps://aka.ms/blhgte

On Sat, Jan 16, 2016 at 5:51 AM -0800, "Gleb Peregud" <notifications@github.commailto:notifications@github.com> wrote:

@domenkozarhttps://github.com/domenkozar Current it does not support this. At the moment it supports only nix-shell. The way it could work is to extend ERL_LIBS env variable when a package is installed with nix-env, but I do not know yet how to do it. If you know how to do it, I'd love to know :)

Reply to this email directly or view it on GitHubhttps://github.com//pull/12409#issuecomment-172208306.

@gleber
Copy link
Contributor

gleber commented Jan 16, 2016

@peti Does it successfully build on your Hydra instance? I have suspicion that it is not hermetic at the moment...

@peti
Copy link
Member

peti commented Jan 16, 2016

Test builds are running at http://hydra.cryp.to/jobset/nixpkgs/erlang-updates ...

@peti
Copy link
Member

peti commented Jan 16, 2016

Well, the rebar3-3.0.0-beta.4 build appears to depend on the impure path /usr/bin/env, which does not exist: http://hydra.cryp.to/build/1554124/nixlog/1/raw. Thus, all builds fail. :-(

@gleber
Copy link
Contributor

gleber commented Jan 16, 2016

@peti Should we fix it up here in master? Or do you usually revert such changes and wait for a PR with fixes in it?

@peti
Copy link
Member

peti commented Jan 16, 2016

IMHO, it would be easiest to follow up with a fix rather than reverting everything.

@gleber
Copy link
Contributor

gleber commented Jan 16, 2016

#12429 fixes the impurity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants