-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Erlang support in Nix #12409
Conversation
This allows us to have a callPackages that includes erlang packages
This changes build-hex.nix so that the buildHex and related functions work correctly in a nix-shell.
This commit moves all the hex based packages to a single namespace. It also moves all the packages to a single file. This is in preparation for the move to a system to generate the hex packages from the hex package store.
The buildErlang function is broken and and leads Engineers down a wrong path. For vanilla erlang that doesn't user rebar3, its better to simply use `stdenv.mkDerivation` along with a set setupHook then the existing functionality.
Building Hex packages is a superset of building with rebar3. There is no need to force folks that use rebar3 but not hex to build with hex. This commit seperates the rebar3 specific bits and the hex specific bits into seperate functions that can be used independently.
This commit adds 187 packages from Hex.pm and documents 100 more that could not be imported for various reasons. The packages where generated by hex2nix.
This commit adds some very minimial documentation to the Nix manual. Hopefully, its enough to get someone started and serve as a first footstep for future documentation writers
This commit allows the installPhase of buildRebar3 to be overridden by the user.
Move registrySnapshot to the erlang-nix github organization
Erlang improvements
By analyzing the blame information on this pull request, we identified @gleber to be a potential reviewer |
Nice. I'd be interested to know how erlang discovers packages installed with |
That's a part of #11748 @peti @sjmackenzie Please take a look. |
@domenkozar Current it does not support this. At the moment it supports only |
Improvements for Erlang support in Nix
Let me second Gleb there. We would love to support it. No clue how at the moment. Sent from Outlook Mobilehttps://aka.ms/blhgte On Sat, Jan 16, 2016 at 5:51 AM -0800, "Gleb Peregud" <notifications@github.commailto:notifications@github.com> wrote: @domenkozarhttps://github.com/domenkozar Current it does not support this. At the moment it supports only nix-shell. The way it could work is to extend ERL_LIBS env variable when a package is installed with nix-env, but I do not know yet how to do it. If you know how to do it, I'd love to know :) Reply to this email directly or view it on GitHubhttps://github.com//pull/12409#issuecomment-172208306. |
@peti Does it successfully build on your Hydra instance? I have suspicion that it is not hermetic at the moment... |
Test builds are running at http://hydra.cryp.to/jobset/nixpkgs/erlang-updates ... |
Well, the |
@peti Should we fix it up here in master? Or do you usually revert such changes and wait for a PR with fixes in it? |
IMHO, it would be easiest to follow up with a fix rather than reverting everything. |
#12429 fixes the impurity |
No description provided.