Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

super-slicer: 2.2.54.2 -> 2.3.56.5 #126671

Merged
merged 1 commit into from Jun 14, 2021
Merged

super-slicer: 2.2.54.2 -> 2.3.56.5 #126671

merged 1 commit into from Jun 14, 2021

Conversation

cab404
Copy link
Member

@cab404 cab404 commented Jun 12, 2021

We are finally up a version!

Motivation for this change

SuperSlicer version bump and minor derivation fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Moredread June 12, 2021 14:39
@cab404 cab404 changed the title super-slicer: 2.2.54.2 -> 2.3.56.4 WIP: super-slicer: 2.2.54.2 -> 2.3.56.4 Jun 12, 2021
@cab404 cab404 changed the title WIP: super-slicer: 2.2.54.2 -> 2.3.56.4 super-slicer: 2.2.54.2 -> 2.3.56.4 Jun 12, 2021
@cab404
Copy link
Member Author

cab404 commented Jun 12, 2021

Submodules should be now enabled — preset files were extracted into them

@cab404
Copy link
Member Author

cab404 commented Jun 12, 2021

Result of nixpkgs-review pr 126671 run on x86_64-linux 1

1 package built:
  • super-slicer

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/545

@baracoder
Copy link
Contributor

👍 gave it a spin, looks good, no exceptions or crashes so far. The test print result looks good, too.
In case "Background processing" is enabled, it will always switch to gcode preview, but there is an option in the GUI preferences tab to disable that behavior supermerill/SuperSlicer#1147 "Switch from 3D view to Preview when sliced"

@cab404
Copy link
Member Author

cab404 commented Jun 13, 2021

Ooof, probably would go ahead and bump it to 5 now it got released)

@cab404
Copy link
Member Author

cab404 commented Jun 13, 2021

Nope, it segfaults right after the boot :D

@cab404
Copy link
Member Author

cab404 commented Jun 13, 2021

Okay, that had some polluted context, it works too.

@cab404
super-slicer: 2.2.54.2 -> 2.3.56.5
5c86827 
We are finally up a version!
@cab404 cab404 changed the title super-slicer: 2.2.54.2 -> 2.3.56.4 super-slicer: 2.2.54.2 -> 2.3.56.5 Jun 13, 2021
@ymatsiuk
Copy link
Contributor

Result of nixpkgs-review pr 126671 run on x86_64-linux 1

1 package built:
  • super-slicer

@ymatsiuk
Copy link
Contributor

Everything seems to work perfectly, clickity-click through UI doesn't cause any errors, all smooth 🎉 Have no printer to test though 🤷🏻

@lovesegfault lovesegfault merged commit 44c5e2b into NixOS:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@Moredread Moredread Awaiting requested review from Moredread

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cab404 @nixos-discourse @baracoder @ymatsiuk @lovesegfault @SuperSandro2000