Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hnix-store-{core,remote}: downgrade to < 0.5 #126840

Merged
merged 1 commit into from
Jun 14, 2021
Merged

haskellPackages.hnix-store-{core,remote}: downgrade to < 0.5 #126840

merged 1 commit into from
Jun 14, 2021

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Jun 14, 2021 •
edited
Loading

hnix 0.13.* doesn't support hnix-store-* >= 0.5 yet, pending some
refactors to get GHC 9.0.x support working. Until that happens,
we downgrade hnix-store-* since nothing needs the new version yet.

haskell-nix/hnix#952

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@sternenseemann
haskellPackages.hnix-store-{core,remote}: downgrade to < 0.5
d49e15e 
hnix 0.13.* doesn't support hnix-store-* >= 0.5 yet, pending some
refactors to get GHC 9.0.x support working. Until that happens,
we downgrade hnix-store-* since nothing needs the new version yet.

haskell-nix/hnix#952
@sternenseemann sternenseemann mentioned this pull request Jun 14, 2021
Closed
@sternenseemann
Copy link
Member Author

@ofborg build haskellPackages.hnix

@sternenseemann sternenseemann mentioned this pull request Jun 14, 2021
Merged
@maralorn maralorn merged commit 601d072 into NixOS:haskell-updates Jun 14, 2021
@maralorn
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn maralorn is a code owner

@Anton-Latukha Anton-Latukha Awaiting requested review from Anton-Latukha

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sternenseemann @maralorn