Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.elgato: init at 2.1.1 #126918

Closed
wants to merge 1 commit into from
Closed

Conversation

siraben
Copy link
Member

@siraben siraben commented Jun 15, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Jun 15, 2021

Result of nixpkgs-review pr 126918 run on x86_64-darwin 1

2 packages built:
  • python38Packages.elgato
  • python39Packages.elgato

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update component-packages.nix and enable the component tests?

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 15, 2021

Result of nixpkgs-review pr 126918 at fea7825 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.elgato
  • python39Packages.elgato
1 suggestion:
  • warning: unused-argument

    Unused argument: packaging.
    Near pkgs/development/python-modules/elgato/default.nix:7:3:

      |
    7 | , packaging
      |   ^
    

Result of nixpkgs-review pr 126918 at fea7825 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.elgato
  • python39Packages.elgato
1 suggestion:
  • warning: unused-argument

    Unused argument: packaging.
    Near pkgs/development/python-modules/elgato/default.nix:7:3:

      |
    7 | , packaging
      |   ^
    

@fabaff
Copy link
Member

fabaff commented Jun 15, 2021

Duplicate of #126047.

I can close my PR if that one here is updated (component-packages and tests).

@siraben
Copy link
Member Author

siraben commented Jun 15, 2021

@fabaff oh, please go ahead with your PR then, thanks.

@siraben siraben closed this Jun 15, 2021
@siraben siraben deleted the elgato-init branch June 15, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants