Revert "php/generic: Allow to extend PHP_INI_SCAN_DIR"

[talyz]

Reverts #125405, which causes issues when PHP is wrapped multiple times, since the same configuration file can end up being loaded multiple times, causing major issues.

[r-rmcgibbo]

Result of nixpkgs-review pr 127677 at 0d9496f run on aarch64-linux 1

2 packages marked as broken and skipped:

• pulseeffects-legacy
• pulseeffects-pw

1 package failed to build:

• libsForQt512.kcachegrind

20 packages built successfully:

• adminer
• php (apacheHttpdPackages.php ,php80)
• arcanist
• bookstack
• drush
• engelsystem
• icingaweb2
• libsForQt5.kcachegrind (libsForQt515.kcachegrind ,plasma5Packages.kcachegrind)
• libsForQt514.kcachegrind
• lsp-plugins
• matomo
• matomo-beta
• nagios
• nextcloud-news-updater
• phoronix-test-suite
• php74
• qcachegrind
• unit
• wp-cli
• yle-dl

1 suggestion:

• warning: missing-patch-comment

  Consider adding a comment explaining the purpose of this patch on the line preceeding.
  Near pkgs/development/interpreters/php/generic.nix:260:19:

      |
  260 |       patches = [ ./fix-paths-php7.patch ] ++ extraPatches;
      |                   ^
  

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

---

Result of nixpkgs-review pr 127677 at 0d9496f run on x86_64-linux 1

1 package failed to build:

• hhvm

1 package skipped due to time constraints:

• libsForQt512.kcachegrind

45 packages built successfully:

• adminer
• php (apacheHttpdPackages.php ,php80)
• arcanist
• bookstack
• drush
• engelsystem
• icingaweb2
• libsForQt5.kcachegrind (libsForQt515.kcachegrind ,plasma5Packages.kcachegrind)
• libsForQt514.kcachegrind
• lsp-plugins
• matomo
• matomo-beta
• nagios
• nextcloud-news-updater
• phoronix-test-suite
• php74
• php74Packages.box
• php74Packages.composer
• php74Packages.deployer
• php74Packages.php-cs-fixer
• php74Packages.php-parallel-lint
• php74Packages.phpcbf
• php74Packages.phpcs
• php74Packages.phpmd
• php74Packages.phpstan
• php74Packages.psalm
• php74Packages.psysh
• php80Packages.box
• php80Packages.composer
• php80Packages.deployer
• php80Packages.php-cs-fixer
• php80Packages.php-parallel-lint
• php80Packages.phpcbf
• php80Packages.phpcs
• php80Packages.phpmd
• php80Packages.phpstan
• php80Packages.psalm
• php80Packages.psysh
• pulseeffects-legacy
• pulseeffects-pw
• qcachegrind
• rss-bridge-cli
• unit
• wp-cli
• yle-dl

1 suggestion:

• warning: missing-patch-comment

  Consider adding a comment explaining the purpose of this patch on the line preceeding.
  Near pkgs/development/interpreters/php/generic.nix:260:19:

      |
  260 |       patches = [ ./fix-paths-php7.patch ] ++ extraPatches;
      |                   ^
  

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

[SuperSandro2000]

Shouldn't the default revert command add the hash of the reverted commit into the message?

[drupol]

Yes, the default log message contains the reverted commit ID, and it is possible to edit it.

Another revert that has been committed: af2d542