Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alsa-lib: 1.2.5 -> 1.2.5.1 #129558

Closed
wants to merge 5 commits into from
Closed

alsa-lib: 1.2.5 -> 1.2.5.1 #129558

wants to merge 5 commits into from

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jul 7, 2021

Motivation for this change

Fixes musl build:

https://git.alsa-project.org/?p=alsa-lib.git;a=commit;h=abe805ed6c7f38e48002e575535afd1f673b9bcd

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nh2 nh2 mentioned this pull request Jul 7, 2021
Merged
5 tasks
@nh2 nh2 changed the base branch from master to staging July 7, 2021 17:29
@nh2 nh2 requested review from FRidh and jonringer as code owners July 7, 2021 17:29
@nh2
Copy link
Contributor Author

nh2 commented Jul 7, 2021

Oops, this is already in staging via merged PR #128746.

@nh2 nh2 closed this Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nh2 @kloenk @marsam @fabaff