Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oh-my-git: Add libudev #134275

Merged
merged 1 commit into from
Aug 16, 2021
Merged

oh-my-git: Add libudev #134275

merged 1 commit into from
Aug 16, 2021

Conversation

Kranzes
Copy link
Member

@Kranzes Kranzes commented Aug 15, 2021

Motivation for this change

Added libudev as a dependency, otherwise oh-my-git will not launch and will error out with the error:
oh-my-git: error while loading shared libraries: libudev.so.1: cannot open shared object file: No such file or directory

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Kranzes
Copy link
Member Author

Kranzes commented Aug 15, 2021

@ofborg eval

@Kranzes
Copy link
Member Author

Kranzes commented Aug 15, 2021

Result of nixpkgs-review pr 134275 run on x86_64-linux 1

1 package built:
  • oh-my-git

1 similar comment
@davidak
Copy link
Member

davidak commented Aug 16, 2021

Result of nixpkgs-review pr 134275 run on x86_64-linux 1

1 package built:
  • oh-my-git

@davidak
Copy link
Member

davidak commented Aug 16, 2021

I can reproduce the issue on nixos-unstable and confirm that this change fixes it.

It is strange that the package broke, since it was not changed and i reviewed it. Maybe libudev was present in earlier nixos versions but not anymore?

@davidak davidak merged commit 71ab3c2 into NixOS:master Aug 16, 2021
@emilytrau
Copy link
Member

This change appears to be causing all PR's to fail the evaluation check (example)

@r-burns
Copy link
Contributor

r-burns commented Aug 16, 2021

#134281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants