oh-my-git: fix strict eval

[r-burns]

libudev is an alias to udev

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[happysalada]

This fails to build with nixpkgs-review with the following

error: anonymous function at /Users/raphael/.cache/nixpkgs-review/pr-134281-1/nixpkgs/pkgs/games/oh-my-git/default.nix:1:1 called without required argument 'libudev'

       at /Users/raphael/.cache/nixpkgs-review/pr-134281-1/nixpkgs/lib/customisation.nix:69:16:

           68|     let
           69|       result = f origArgs;
             |                ^
           70|

       … while evaluating 'makeOverridable'

       at /Users/raphael/.cache/nixpkgs-review/pr-134281-1/nixpkgs/lib/customisation.nix:67:24:

           66|   */
           67|   makeOverridable = f: origArgs:
             |                        ^
           68|     let

       … from call site

       at /Users/raphael/.cache/nixpkgs-review/pr-134281-1/nixpkgs/lib/customisation.nix:121:8:

          120|       auto = builtins.intersectAttrs (lib.functionArgs f) autoArgs;
          121|     in makeOverridable f (auto // args);
             |        ^
          122|

       … while evaluating 'callPackageWith'

       at /Users/raphael/.cache/nixpkgs-review/pr-134281-1/nixpkgs/lib/customisation.nix:117:35:

          116|   */
          117|   callPackageWith = autoArgs: fn: args:
             |                                   ^
          118|     let

       … from call site

       at /Users/raphael/.cache/nixpkgs-review/pr-134281-1/nixpkgs/pkgs/top-level/all-packages.nix:3072:15:

         3071|
         3072|   oh-my-git = callPackage ../games/oh-my-git { };
             |               ^
         3073|
https://github.com/NixOS/nixpkgs/pull/134281 failed to build

I'm checking where this could come from.

[r-burns]

Yeah, you can't run nixpkgs-review when the before/after state fails eval. It needs a successful eval for both to compute the list of changed paths.

[happysalada]

TIL !
Also the only platform supported is x86_64-linux, I wanted to help on that one, but I'm afraid I can't test it.
It looks right though.

[davidak]

Result of nixpkgs-review pr 134281 run on x86_64-linux 1

[davidak]

libudev is an alias to udev

what do you want to say? are aliases not allowed anymore? why does the check have an error and nixpkgs-review not? why does this fix the issue?

udev is an alias to sysdemd btw

i will merge asap if i can verify that the change makes sense

[r-burns]

As I understand it, aliases are disallowed in ofborg eval (since NixOS/ofborg#250) and the purpose of the aliases is more for backwards compatibility so that we don't break e.g. users' configs/overlays.

[davidak]

I see. Then why does this change fix it? udev is an alias as well!

[r-burns]

udev isn't a real "alias", it's just an expression with the same value as systemd.
Only aliases in top-level/aliases.nix have strict eval semantics.

[Kranzes]

Sorry for the mess guys :(