Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oh-my-git: clearify dependency #134287

Merged
merged 1 commit into from
Aug 16, 2021
Merged

oh-my-git: clearify dependency #134287

merged 1 commit into from
Aug 16, 2021

Conversation

davidak
Copy link
Member

@davidak davidak commented Aug 16, 2021 •
edited

Motivation for this change

the actual dependency is libudev

follow up do #134281

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@davidak
oh-my-git: clearify dependency
e196a3e 
the actual dependency is libudev
@davidak
Copy link
Member Author

davidak commented Aug 16, 2021

Result of nixpkgs-review pr 134287 run on x86_64-linux 1

@happysalada happysalada merged commit 6978917 into master Aug 16, 2021
@davidak davidak deleted the davidak-patch-1 branch August 16, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidak @r-burns @happysalada