-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghcjs: init at 8.10.7 #137066
ghcjs: init at 8.10.7 #137066
Conversation
f992828
to
11ba1b2
Compare
I don't know very much about GHCJS, so I'm hesitant to merge this without at least a look-over from someone more knowledgeable about GHCJS. Off the top of my head, I think @Ericson2314 and @angerman are both using GHCJS at their respective companies, so maybe they'd be able to give a good review. Also, @dfordivam we have a Hydra jobset for Haskell in |
@dfordivam Ah, one last thing. Can you set the base branch to the |
915428b
to
7a0b830
Compare
7a0b830
to
b8ae9a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the little nit I left, this is good
Oh, and maybe |
I checked, and that shouldn't cause collisions on 21.05 or 20.09 either, where we might want to backport, so yes let's do that rename. |
(generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh)
b8ae9a8
to
0918598
Compare
ghcjs is quite big and 2.9GB over the output limit on Hydra at the moment, so we can't provide binary cache for it. Any ideas how we can cut this down? Building the libraries separately and individually could be a solution, but not sure if it is even possible.
|
Building the libraries separately is always something I'm keen to do in general. I'll try to see if we can investigate. |
@dfordivam did report that the output was significantly smaller on their machine, so I'm a bit confused what exactly is going wrong on Hydra and my machine. |
@sternenseemann I just managed to build ghcjs on Darwin, and the output turns out to be 3.9G
Given this I looked back at the linux machine and figured out that my number were wrong due to zfs compression. This is the real value..
|
So this is in line with the 4G llvm-aarch64 build we had? I hope that the ghcjs-in-ghc will be smaller, as it will eventually drop some packages from the rather large dependency closure of ghcjs. |
@angerman I don't think ghcjs' (Haskell) dependency closure is the problem (if you mean that). The problem is rather the |
@angerman yeah we should very soon ™ be able to build GHC itself, RTS, base by themselves for regular GHC, and I hope that will be the case for GHCJS too. |
Motivation for this change
Adds the ghcjs back to nixpkgs
fixes #133271
And contains a few other commits to make this work.
On darwin the llvm_13 (required by emscripten) fails, and therefore this change could not be tested.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)