New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.mypy-protobuf: Add missing inputs #138198
Conversation
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
29c3d06
to
8ae61d0
Compare
Result of 1 package skipped due to time constraints:
8 packages built successfully:
3 suggestions:
Result of 1 package skipped due to time constraints:
8 packages built successfully:
3 suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 138198 run on x86_64-linux 1
9 packages built:
- or-tools
- python38Packages.mypy-protobuf
- python38Packages.ortools
- python38Packages.types-futures
- python38Packages.types-protobuf
- python39Packages.mypy-protobuf
- python39Packages.ortools
- python39Packages.types-futures
- python39Packages.types-protobuf
Motivation for this change
Commit 96e5573 bumped mypy-protobuf without adding its newly required build inputs, and the resulting derivation fails to build. Fix it.
(Cc @mweinelt.)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)