Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mypy-protobuf: Add missing inputs #138198

Merged
merged 3 commits into from Sep 17, 2021

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Sep 16, 2021

Motivation for this change

Commit 96e5573 bumped mypy-protobuf without adding its newly required build inputs, and the resulting derivation fails to build. Fix it.

(Cc @mweinelt.)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 17, 2021

Result of nixpkgs-review pr 138198 at 8ae61d0 run on aarch64-linux 1

1 package skipped due to time constraints:
  • or-tools
8 packages built successfully:
  • python38Packages.mypy-protobuf
  • python38Packages.ortools
  • python38Packages.types-futures
  • python38Packages.types-protobuf
  • python39Packages.mypy-protobuf
  • python39Packages.ortools
  • python39Packages.types-futures
  • python39Packages.types-protobuf
3 suggestions:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/mypy-protobuf/default.nix:17:0:

       |
    17 |     description = "Generate mypy stub files from protobuf specs";
       | ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/types-futures/default.nix:13:0:

       |
    13 |     description = "Typing stubs for futures";
       | ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/types-protobuf/default.nix:15:0:

       |
    15 |     description = "Typing stubs for protobuf";
       | ^
    

Result of nixpkgs-review pr 138198 at 8ae61d0 run on x86_64-linux 1

1 package skipped due to time constraints:
  • or-tools
8 packages built successfully:
  • python38Packages.mypy-protobuf
  • python38Packages.ortools
  • python38Packages.types-futures
  • python38Packages.types-protobuf
  • python39Packages.mypy-protobuf
  • python39Packages.ortools
  • python39Packages.types-futures
  • python39Packages.types-protobuf
3 suggestions:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/types-futures/default.nix:13:0:

       |
    13 |     description = "Typing stubs for futures";
       | ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/mypy-protobuf/default.nix:17:0:

       |
    17 |     description = "Generate mypy stub files from protobuf specs";
       | ^
    
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/types-protobuf/default.nix:15:0:

       |
    15 |     description = "Typing stubs for protobuf";
       | ^
    

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 138198 run on x86_64-linux 1

9 packages built:
  • or-tools
  • python38Packages.mypy-protobuf
  • python38Packages.ortools
  • python38Packages.types-futures
  • python38Packages.types-protobuf
  • python39Packages.mypy-protobuf
  • python39Packages.ortools
  • python39Packages.types-futures
  • python39Packages.types-protobuf

@jonringer jonringer merged commit c4b5000 into NixOS:master Sep 17, 2021
@andersk andersk deleted the mypy-protobuf-inputs branch December 26, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants