Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paperless-ng: fix redis connection #138438

Merged
merged 1 commit into from
Sep 24, 2021
Merged

paperless-ng: fix redis connection #138438

merged 1 commit into from
Sep 24, 2021

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Sep 18, 2021

Motivation for this change

paperless-ng is not yet compatible with aioredis 2, which was updated
with the last python update, so pin its version to 1.3.1.

Note that #138294 is needed to build ocrmypdf/paperless-ng.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

paperless-ng is not yet compatible with aioredis 2, which was updated
with the last python update, so pin its version to 1.3.1.
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but didn't run the software

@dotlambda
Copy link
Member

@ofborg eval

@dotlambda
Copy link
Member

Do you have an idea about why two tests fail on aarch64?

@Flakebi
Copy link
Member Author

Flakebi commented Sep 23, 2021

No idea, it looks like somehow the consumed file is incomplete or corrupted as it fails here: https://github.com/jonaswinkler/paperless-ng/blob/cd43bc1f660f081325c3d03e758cf9436d3e604f/src/documents/tests/test_management_consumer.py#L78

@dotlambda
Copy link
Member

Do you mind filing an issue upstream?

@Flakebi
Copy link
Member Author

Flakebi commented Sep 24, 2021

I just had a look at the initial pr (#123046) and aarch64 tests failed there too, so it’s not a regression. If I find the time, I’ll look more at the failures.

@dotlambda dotlambda merged commit 5cdf737 into NixOS:master Sep 24, 2021
@Flakebi Flakebi deleted the paperless branch September 25, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants