Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python3-eventlib: init at 0.3.0 #138591

Merged
merged 2 commits into from Sep 20, 2021

Conversation

charlieshanley
Copy link
Contributor

@charlieshanley charlieshanley commented Sep 19, 2021

Motivation for this change

Split from #136924. This adds a dependency of blink-qt and sipclients3, which I intend to add.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@charlieshanley charlieshanley changed the title python3-eventlib: init at 0.3.0 python3Packages.python3-eventlib: init at 0.3.0 Sep 20, 2021
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 138591 run on x86_64-linux 1

2 packages built:
  • python38Packages.python3-eventlib
  • python39Packages.python3-eventlib

@jonringer jonringer merged commit 762ad92 into NixOS:master Sep 20, 2021
pname = "python3-eventlib";
version = "0.3.0";

disabled = !isPy3k;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use pythonOlder instead.


propagatedBuildInputs = [ zope_interface twisted greenlet ];

dontUseSetuptoolsCheck = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are tests disabled? Please add a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants