Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menumaker,gnome-doc-utils: switch to python3 #138736

Merged
merged 2 commits into from
Sep 26, 2021
Merged

menumaker,gnome-doc-utils: switch to python3 #138736

merged 2 commits into from
Sep 26, 2021

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Sep 20, 2021 •
edited
Loading

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin
menumaker: 0.99.12 -> 0.99.13 and switch to python3
e2ccaaa 
according to the homepage the niminum python version is
2.7 but it should also run on python3
@Artturin
Copy link
Member Author

Artturin commented Sep 20, 2021 •
edited
Loading

xiphos failure is pre-existing

Result of nixpkgs-review pr 138736 run on x86_64-linux 1

1 package failed to build:
  • xiphos
8 packages built:
  • cinnamon.cinnamon-common
  • cinnamon.cinnamon-gsettings-overrides
  • cinnamon.cinnamon-screensaver
  • cinnamon.muffin
  • dasher
  • gnome-doc-utils (gnome_doc_utils)
  • menumaker
  • pdfmod

@ofborg ofborg bot requested a review from romildo September 20, 2021 22:14
romildo
romildo reviewed Sep 21, 2021
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The menumaker changes looks good to me. Tested locally.

@ofborg ofborg bot requested a review from romildo September 22, 2021 01:44
@Artturin Artturin merged commit bd2cc00 into NixOS:master Sep 26, 2021
@Artturin Artturin deleted the vartopy3 branch September 26, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@romildo romildo Awaiting requested review from romildo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Artturin @romildo @SuperSandro2000