Replace references to all-packages.nix, by references to the top-level #13896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l of nixpkgs repository.
|
By analyzing the blame information on this pull request, we identified @copumpkin, @edolstra and @pikajude to be potential reviewers |
nbp
added
0.kind: enhancement
6.topic: closure-size
8.has: clean-up
and removed
6.topic: closure-size
labels
edolstra
added a commit
that referenced
this pull request
Mar 14, 2016
Replace references to all-packages.nix, by references to the top-level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is extracted from the larger pull request #10851 , and was requested as a cleaner approach than was was done in #10307.
This change is useful, as we now have only a single point of entry in
all-packages.nix, which is the top-leveldefault.nixfile of nixpkgs.Having this change, will allow to split
all-packages.nixfile into one which contains the logic, and another one which contains the list of packages. Thus giving us the ability to re-indent this one correctly.cc @domenkozar