Split all-packages.nix #10307
Closed
Split all-packages.nix #10307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re any overwritten packages.
|
cc @edolstra |
|
The error https://travis-ci.org/NixOS/nixpkgs/builds/84793391#L116 from travis looks genuine. It would be great to get that fixed. Otherwise, I'm in favor of merging this patch: 👍. Does anyone consider this re-factoring controversial? |
|
I rebased this work on top of another pull request that is cleaning the logic of override packages and stdenv. I am currently working on a security update branch for the NixCon, which is based on a similar modification. I will get back to this, hopefully before NixCon ;) |
| , platform ? null | ||
| , config ? {} | ||
| }: | ||
|
|
||
| rec { | ||
| allPackages = import ../../top-level/all-packages.nix; | ||
| allPackages = import ../../top-level/all-packages-wrapper.nix; |
There was a problem hiding this comment.
Why not refer to ../../.. (i.e. the top-level default.nix)?
|
This work is now addressed as part of #10851. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is moves the header & footer of
all-packages.nixinto a separated file namedall-packages-wrapper.nix. To do so, I added a new list of arguments to theall-packages.nixwhich is the explicit list of dependencies, and that we can reduce over time by making it part of the list of paclkages. (system,bootStdenv,noSysDir, …)Later we should change the way we handle self-references (
self&pkgs) such that we can follow the same scheme as done in haskellPackages (self&super).These modifications are made to simplify the way we can add additional logic to our list of packages.
Note: This patch does not change the sha1 of derivations.
Note: This patch fix the indentation issue of
all-packages.nix.cc @peti @domenkozar @edolstra