Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.unite: remove manually packaging and use extension override #140298

Merged
merged 1 commit into from Oct 3, 2021
Merged

gnomeExtensions.unite: remove manually packaging and use extension override #140298

merged 1 commit into from Oct 3, 2021

Conversation

rhoriguchi
Copy link
Contributor

@rhoriguchi rhoriguchi commented Oct 2, 2021

Motivation for this change

Depends on #140285. Since the current version in extensions.json is lower than the packed one.

Use the new override logic from #137131 to add buildInputs.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 2, 2021
@piegamesde
Copy link
Member

Looks great, thank you. Would you mind also adding yourself to the maintainers of that package using the override?

@rhoriguchi
Copy link
Contributor Author

Looks great, thank you. Would you mind also adding yourself to the maintainers of that package using the override?

Sure, I've added myself.

@SuperSandro2000 SuperSandro2000 merged commit 375e8be into NixOS:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants