Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-bindgen-cli: 0.2.75 -> 0.2.78 #141488

Merged
merged 1 commit into from
Oct 16, 2021
Merged

wasm-bindgen-cli: 0.2.75 -> 0.2.78 #141488

merged 1 commit into from
Oct 16, 2021

Conversation

TethysSvensson
Copy link
Contributor

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Rizary, Ma27 and nitsky October 13, 2021 11:26
SuperSandro2000
SuperSandro2000 reviewed Oct 13, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use fetchCrate to remove the lock file from the nixpkgs repo?

@TethysSvensson
Copy link
Contributor Author

can we use fetchCrate to remove the lock file from the nixpkgs repo?

That sounds like a good idea, but I don't really have time to get pulled into a cleanup discussion. Could it be done in a follow-up PR?

@figsoda
Copy link
Member

figsoda commented Oct 16, 2021

Result of nixpkgs-review pr 141488 run on x86_64-linux 1

1 package built:
  • wasm-bindgen-cli

figsoda
figsoda approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make a follow up

@figsoda figsoda merged commit 9495d51 into NixOS:master Oct 16, 2021
@figsoda
Copy link
Member

figsoda commented Oct 16, 2021

wasm-bindgen-cli's tests doesn't work outside the repository, should I keep it this way or do fetchCrate with doCheck = false; or try to patch the tests, which wouldn't be trivial, but it would be smaller than the current path

@figsoda figsoda mentioned this pull request Oct 17, 2021
Merged
12 tasks
@TethysSvensson TethysSvensson deleted the wasm-bindgen-cli@0.2.78 branch September 28, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@nitsky nitsky nitsky approved these changes

@figsoda figsoda figsoda approved these changes

@Rizary Rizary Awaiting requested review from Rizary

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TethysSvensson @figsoda @nitsky @SuperSandro2000