coursier: Rename binary to cs #142254
Merged
coursier: Rename binary to cs #142254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
adelbertc
approved these changes
Oct 19, 2021
NeQuissimus
approved these changes
Oct 20, 2021
| @@ -348,6 +348,8 @@ In addition to numerous new and upgraded packages, this release has the followin | |||
|
|
|||
| - `boot.kernelParams` now only accepts one command line parameter per string. This change is aimed to reduce common mistakes like "param = 12", which would be parsed as 3 parameters. | |||
|
|
|||
| - The `coursier` package's binary was renamed from `coursier` to `cs`. Completions which haven't worked for a while should now work with the renamed binary. To keep using `coursier`, you can create a shell alias. | |||
There was a problem hiding this comment.
The release notes are for important changes. I am not sure if this is actually an important change.
There was a problem hiding this comment.
It's breaking for anyone who uses coursier in any builds - if that was me, I would say it's important :) (I'm not using this in prod, but I do have usages of coursier that are impacted)
fabianhjr
added a commit
to LibreCybernetics/nixpkgs
that referenced
this pull request
Oct 29, 2021
After NixOS#142254 coursier provides its binary as /bin/cs rather than /bin/coursier
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The binary provided by other installation of Coursier is called
cs. The completions also don't work withcoursierunless it's defined as an alias forcs.Things done
coursierbinary tocssandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)