Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coursier: Rename binary to cs #142254

Merged
merged 1 commit into from
Oct 21, 2021
Merged

coursier: Rename binary to cs #142254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions nixos/doc/manual/from_md/release-notes/rl-2111.section.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,6 +1128,15 @@ Superuser created successfully.
would be parsed as 3 parameters.
</para>
</listitem>
<listitem>
<para>
The <literal>coursier</literal> package’s binary was renamed
from <literal>coursier</literal> to <literal>cs</literal>.
Completions which haven’t worked for a while should now work
with the renamed binary. To keep using
<literal>coursier</literal>, you can create a shell alias.
</para>
</listitem>
</itemizedlist>
</section>
<section xml:id="sec-release-21.11-notable-changes">
Expand Down
2 changes: 2 additions & 0 deletions nixos/doc/manual/release-notes/rl-2111.section.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,8 @@ In addition to numerous new and upgraded packages, this release has the followin

- `boot.kernelParams` now only accepts one command line parameter per string. This change is aimed to reduce common mistakes like "param = 12", which would be parsed as 3 parameters.

- The `coursier` package's binary was renamed from `coursier` to `cs`. Completions which haven't worked for a while should now work with the renamed binary. To keep using `coursier`, you can create a shell alias.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release notes are for important changes. I am not sure if this is actually an important change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's breaking for anyone who uses coursier in any builds - if that was me, I would say it's important :) (I'm not using this in prod, but I do have usages of coursier that are impacted)


## Other Notable Changes {#sec-release-21.11-notable-changes}


Expand Down
8 changes: 4 additions & 4 deletions pkgs/development/tools/coursier/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ in stdenv.mkDerivation rec {
nativeBuildInputs = [ makeWrapper ];

buildCommand = ''
install -Dm555 $src $out/bin/coursier
patchShebangs $out/bin/coursier
wrapProgram $out/bin/coursier --prefix PATH ":" ${jre}/bin
install -Dm555 $src $out/bin/cs
patchShebangs $out/bin/cs
wrapProgram $out/bin/cs --prefix PATH ":" ${jre}/bin

# copy zsh completion
install -Dm755 ${zshCompletion} $out/share/zsh/site-functions/_coursier
install -Dm755 ${zshCompletion} $out/share/zsh/site-functions/_cs
'';

passthru.updateScript = writeScript "update.sh" ''
Expand Down