python3.pkgs.dbus-python: 1.2.16 -> 1.2.18

[alyssais]

Motivation for this change

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[SuperSandro2000]

Can you please clarify the package name? It is python3Packages.dbus, not python3Packages.dbus-python.

Not sure where I did the typo in nixpkgs-review but I got it working now.

[jtojnar]

Changes look okay, except that it breaks python2.pkgs.dbus-python. It can be easily fixed using the following patch but not sure if we should care, especially when Python 2 support will be removed in the next version anyway.

--- a/pkgs/development/python-modules/dbus/default.nix
+++ b/pkgs/development/python-modules/dbus/default.nix
@@ -32,6 +32,10 @@ buildPythonPackage rec {
   doCheck = isPy3k;
   checkInputs = [ dbus.out pygobject3 ];
 
+  configureFlags = [
+    "PYTHON_VERSION=${lib.versions.major python.version}"
+  ];
+
   meta = {
     description = "Python DBus bindings";
     license = lib.licenses.mit;

[SuperSandro2000]

Changes look okay, except that it breaks python2.pkgs.dbus-python. It can be easily fixed using the following patch but not sure if we should care, especially when Python 2 support will be removed in the next version anyway.

We usually only care if nixops breaks otherwise we ignore it.

[SuperSandro2000]

nixops already fails to build on python2.7-ruamel-yaml-clib

[vcunat]

not sure if we should care

Maybe make it fail during evaluation time already?

BTW, example package depending on this: https://hydra.nixos.org/build/158735128 (sounds insignificant to me)

[vcunat]

I also see netatalk depending on it, /cc maintainer @jcumming.

[vcunat]

... and pam_usb package, including NixOS security.pam.usb. (no maintainers, doesn't look important either)