system/boot/initrd-network: Add explicit enable option for UDHCPC #147088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pennae
reviewed
Nov 26, 2021
Shados
force-pushed
the
initrd-network-enable-udhcpc
branch
from
1e51a26
to
3377379
Compare
stale
bot
added
the
2.status: stale
Shados
force-pushed
the
initrd-network-enable-udhcpc
branch
from
3377379
to
d64c8b8
Compare
|
Updated for some bitrot (re. change to markdown doc). |
The default value implements the current behaviour of enabling UDHCPC in initrd if the user has either the global or any per-interface `useDHCP` option enabled, but making it an explicit option means that the user can enable UDHCPC in initrd under other circumstances.
Shados
force-pushed
the
initrd-network-enable-udhcpc
branch
from
d64c8b8
to
d4f1749
Compare
stale
bot
removed
the
2.status: stale
|
...closing because this functionality was merged in #240406. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value retains the current behaviour of enabling UDHCPC in initrd if the user has either the global or any per-interface
useDHCPoption enabled, but making it an explicit option means that the user can enable UDHCPC in initrd under other circumstances.Motivation for this change
I have a desktop system with an encrypted root, that I want to be able to decrypt over SSH when required, but that I also use networkmanager for normally. Using DHCP in the initrd is more preferable to me than setting an explicit static IP for the initrd.
Things done
sandbox = trueset innix.conf? (See Nix manual)initrd-network-openvpntest fails, but in the same way it was prior to my change)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes