-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imhex: init at 1.11.1 #148646
imhex: init at 1.11.1 #148646
Conversation
1d9a84d
to
f1b9ae2
Compare
version = "1.11.1"; | ||
|
||
src = fetchFromGitHub { | ||
fetchSubmodules = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have all the package that are vendored in nixpkgs? If so we can remove this.
install -D plugins/builtin/builtin.hexplug $out/bin/plugins/builtin.hexplug | ||
install -D plugins/libimhex/libimhex.so $out/lib/libimhex.so | ||
|
||
cp -R ${patterns_src}/* $out/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want those files under /bin? They do not belong there and should probably go under /share/imhex/.
install -D plugins/builtin/builtin.hexplug $out/bin/plugins/builtin.hexplug | |
install -D plugins/libimhex/libimhex.so $out/lib/libimhex.so | |
cp -R ${patterns_src}/* $out/bin | |
install -D plugins/builtin/builtin.hexplug $out/share/imhex/plugins/builtin.hexplug | |
install -D plugins/libimhex/libimhex.so $out/lib/libimhex.so | |
cp -R ${patterns_src}/* $out/bin |
ah @SuperSandro2000 I changed |
What got broken exactly? We want to run fixupPhase and figure out what is broken. Maybe stripping? We could disable that with dontStrip. |
I was interested in running ImHex, I rebased this pull request on the latest main: I was able to run the program successfully, but when I tried to open a file, I got a crash before the dialog displayed:
I tried to fix this issue using However, I was able to proceed by setting
After that I could open the file dialog successfully. I used
I thought only
Hope this is helpful. Please let me know if you're aware of how to configure |
I was unable to download the standard library from the Content Store to run patterns, so I bumped the version from I needed to switch to a newer version of GCC, and to add a After upgrading, I was able to pull down the standard library, and to evaluate patterns using |
Motivation for this change
I packaged the hex editor imhex
and removed my own deprecated package
rmount
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes