roon-server: 1.8-850 -> 1.8-880 #152251
roon-server: 1.8-850 -> 1.8-880 #152251
Conversation
|
@anttisoikkeli This PR needs to be tested, I'm currently away from home and cannot test this in my Roon server. |
|
Tested and confirmed operating as expected on my NixOS machine. |
|
Successfully created backport PR #152360 for |
|
@Steell did you actually test to connect to it? Mine is running as well, but my Roon Remote fails to connect to it. Tested on Android (Note 10 Plus) and iPad (2019 model) and both have latest version of Roon Remote. Android gives Connecting/Connection failed -loop and iPad can't even find it. Systemctl tells me that it's running on 1.8-880. Nothing has changed in the system lately. I'm 98% certain that this relates to the new version of roon-server somehow. I'm guessing that adding libtasn1 isn't enough after all and some missing library is now failing silently or then the new version needs some new open ports. Ping @lovesegfault as well. Sorry for reacting this late, but I haven't been able to play with this before now. |
|
It's going to take me a hot minute to be able to test or debug this. My Roon server is in storage and I'm in another continent for another few weeks, and then I need to find a house before I can reassemble everything. My recommendation is that we either revert this for now or that someone debug the issue without my help. |
|
I can try to debug this as well. Personally at least, I'm not in a hurry. Note that reverting is not really an option. New versions of Roon Remotes (that get updated automatically in mobile devices) are not backwards compatible with the old roon-server and those can't be downgraded. We would have a broken system anyway, even if we reverted all the changes. That's why I created the issue in the first place. I would say that let's just accept that it's broken and debug/fix this when we have time. Reverting creates just extra work without any benefits. |
|
It's firewall! |
Ah, interesting :) Can you try stealing my firewall rules and seeing if it fixes it? |
|
Those are already identical to: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/audio/roon-server.nix There is something else. I also tried to allow all TCP and UDP ports with this and no success: networking.firewall.allowedTCPPortRanges = [ { from = 0; to = 65353; } ];
networking.firewall.allowedUDPPortRanges = [ { from = 0; to = 65353; } ]; |
|
Found it, this fixes the problem: Now I just need to find out why the lines from my previous comment didn't fix anything, but that's not related to this ticket :) EDIT: Ports above 9332 not needed. |
During the bump to 1.8-880 these became necessary, debugging took place in the [relevant PR][1]. [1]: NixOS#152251
Motivation for this change
Closes: #152104
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes