Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/roon-server: open TCP ports 9330-9332 in firewall #154180

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

lovesegfault
Copy link
Member

Motivation for this change

During the bump to 1.8-880 these became necessary, debugging took place
in the relevant PR.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

During the bump to 1.8-880 these became necessary, debugging took place
in the [relevant PR][1].

[1]: NixOS#152251
@lovesegfault
Copy link
Member Author

@anttisoikkeli is this sufficient to fix 1.8-880?

@anttisoikkeli
Copy link

@lovesegfault sorry for the late reply. At least for me $ sudo iptables -I INPUT 1 -p tcp --dport 9330:9332 -j ACCEPT fixed the problem, but I haven't been able to fix it by changing the configuration. Will try again with reboot. There maybe something I don't know about how it all plays out (like, does NixOS edit iptables on reboot or something). Will get back during today if I get it working by just editing the config, without running manual iptables commands.

@anttisoikkeli
Copy link

And confirmed, this fixes the problem.

The reason I didn't get it working earlier from config:

I was using:

nixpkgs.config.networking.firewall.allowedTCPPortRanges

While I should had been using:

networking.firewall.allowedTCPPortRanges

@lovesegfault lovesegfault merged commit 7e395a4 into NixOS:master Jan 24, 2022
@lovesegfault lovesegfault deleted the roon-server-firewall-fix branch January 24, 2022 02:36
@lovesegfault
Copy link
Member Author

Thanks for confirming, glad it's all working again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants