Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kresd: fix IPv6 scope syntax #153610

Merged
merged 2 commits into from
Jan 11, 2022
Merged

nixos/kresd: fix IPv6 scope syntax #153610

merged 2 commits into from
Jan 11, 2022

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Jan 5, 2022 •
edited

Motivation for this change

Fix #153485

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
knot-resolver: 5.4.3 -> 5.4.4
1071b77 
This is basically just no-op.  Only version number changes.
https://gitlab.nic.cz/knot/knot-resolver/-/tags/v5.4.4
@vcunat
nixos/kresd: fix IPv6 scope syntax
180213a 
The systemd syntax is suprising to me, but I suppose it's worth being
compatible as people might be sharing it with other modules.
Our regexp is lenient on IPv6 address part, so this is actually
backwards compatible (i.e. you can put the scope at either place).
@vcunat vcunat requested a review from grahamc January 5, 2022 15:08
@vcunat
Copy link
Member Author

vcunat commented Jan 5, 2022

I manually tested that some IPv4 and IPv6 specs generate the right lua line.

@vcunat vcunat merged commit ddc24ff into NixOS:master Jan 11, 2022
@vcunat vcunat deleted the p/knot-resolver branch January 11, 2022 11:56
@github-actions github-actions bot mentioned this pull request Jan 11, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #154531 for release-21.11.

@puppe puppe mentioned this pull request Jan 26, 2022
Closed
@leona-ya leona-ya mentioned this pull request Jan 3, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

services.kresd.listenPlain says it supports ListenStream syntax from systemd.socket but doesn't
1 participant
@vcunat