nixos/kresd: fix port only regex #278555
Merged
nixos/kresd: fix port only regex #278555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output is expected to be a list [ hostname, port, optional ipv6 scope ], but the current regex only outputs [ port ], when only a port is given as address.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
kloenk
approved these changes
Jan 6, 2024
delroth
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3356 |
fpletz
approved these changes
Jan 29, 2024
|
Successfully created backport PR for |
1 task
|
Thanks. I'm sorry for my lack of timely resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently a
list index 1 is out of boundserror is thrown when the port only syntax is used in kresd. Example:services.kresd.listenPlain = [ "53" ]This regression was introduced in #153610.
The output is expected to be a list
[ hostname, port, optional ipv6 scope ], but the current regex only outputs[ port ], when only a port is given as address.We cannot use
()because that's unsupported on darwin (#100592).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.