pgadmin4: init at 6.3 #154764

gador · 2022-01-12T13:59:47Z

Motivation for this change

pgadmin3 was last updated in 2017 and currently doesn't build due to an openssl insecurity.
pgadmin4 is the replacement to it, but isn't yet available in nixpkgs.

Building on the work of @mkg20001 at #128986 I finished the work on the pgadmin4 derivation.

This PR also includes some updates to recent python packages (either due to requirements by pgadmin4 or due to build errors).

Due to the way the pgadmin4 build process works, the derivation primarily builds a python wheel and includes a bundle from yarn build files.

One major thing that needs to be discussed is the way pgadmin4 in itself works: It opens a webserver on port 5050 on localhost and needs to save state in /var/lib/pgadmin4 and saves logs to /var/log/pgadmin4. One needs to either run as root, or create the directories with user permissions. The data directory can be overwritten (either at build time, or later by placing a config file in /etc/pgadmin/config_system.py). See here.

In the long run, it probably will make sense to implement a system module with a configurable port, listen address and state directory.

Right now, pgAdmin4 builds and runs (as long as the directories above have been created).

Things done

SuperSandro2000

Please split your PRs into smaller ones if you want them to be merged in time.

Please add a pythonImportsCheck to all packages.

Also can we identify the commit that causes 500+ rebuilds and push that to staging? I guess it is eventlet.

@mkg20001 do you want to maintain the packages in this PR? Also your commits are not verified.

pkgs/development/python-modules/dnspython/default.nix

pkgs/development/python-modules/eventlet/default.nix

pkgs/development/python-modules/flask-compress/default.nix

pkgs/development/python-modules/flask-gravatar/default.nix

pkgs/tools/admin/pgadmin/default.nix

SuperSandro2000 · 2022-01-13T12:58:19Z

pkgs/tools/admin/pgadmin/default.nix

+  # pgadmin offers a wide range of tests in web/regression
+  # unfortunately most of them require a PostgresServer in the
+  # test environment. Also, the data and log directories need
+  # to exist in the test environment.


This can be done in a VM test. We should probably do that to make sure dependency updates do not cause regressions.

How would you go about it?

I didn't write a test yet but I would go into https://github.com/NixOS/nixpkgs/tree/master/nixos/tests and look at other ones and try to find something similar to my use case.

Hi @SuperSandro2000
I added the test suite which runs all python related tests. I'd love to have your feedback on them 👍

pkgs/top-level/all-packages.nix

pkgs/development/python-modules/eventlet/default.nix

gador · 2022-01-14T22:27:36Z

Hi @SuperSandro2000 thanks for your quick and very thorough review!
I revised everything according to your suggestions.

Do you want me to split this PR into the separate packages? Or can we leave it as one?

I reverted the chages to eventlet, but it still evaluates to 547 updated packages. Also some of those changes break packages with very narrow requirements (e.g. mcstatus has dnspython==2.1.0 as requirement). How do I find the commit that causes the mass-rebuild?

Should I split the updated packages into isolated PR's and fix any downstream breakages? How is this usually managed?

Thanks for your time!

needed for pgadmin4 init NixOS#154764

mkg20001 · 2022-02-26T12:02:30Z

pgadmin3 commit message needs adjustement, should be pgadmin3: move

pgadmin4 version 6.5 came out, we could update it in this pr or leave that for later

gador · 2022-02-26T12:05:42Z

pgadmin3 commit message needs adjustement, should be pgadmin3: move

fixed.

pgadmin4 version 6.5 came out, we could update it in this pr or leave that for later

I'd leave it for later. Let's first get a working pgadmin into nixpkgs and update it to 6.5 in a later PR

mkg20001 · 2022-02-26T12:07:17Z

I think maybe squash the pgadmin4 commits, it's common to just have one init commit on package creation. Then I'll merge it, seems good as is.

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>

moved pgadmin3 to pgadmin4 and renamed to 3.nix added an alias for pgadmin->pgadmin4 Signed-off-by: florian on nixos (Florian Brandes) <florian.brandes@posteo.de>

gador · 2022-02-26T12:21:16Z

I think maybe squash the pgadmin4 commits, it's common to just have one init commit on package creation. Then I'll merge it, seems good as is.

done. I also (re-)added the alias. It must have gone lost on a rebase to master..

gador · 2022-02-26T12:56:40Z

awesome! Thanks for your help 🥳

nixos-discourse · 2022-03-07T20:24:52Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cant-install-postgres4-from-unstable/18068/1

ajs124 · 2022-03-14T23:55:45Z

pkgs/top-level/all-packages.nix

-  pgadmin = callPackage ../applications/misc/pgadmin {
+  pgadmin4 = callPackage ../tools/admin/pgadmin { };
+
+  pgadmin3 = callPackage ../tools/admin/pgadmin/3.nix {


I know this is already merged, but what were the reasons for keeping pgadmin3 around?

in case someone needs it. I think we should get rid of it after 22.05 gets released tho.

pgadmin3 was last updated in 2017 and currently doesn't build due to an openssl insecurity.

We are basically accumulating literal trash.

in case someone needs it. I think we should get rid of it after 22.05 gets released tho.

What does pgadmin3 provide that pgadmin4 doesn't? This is NixOS unstable, remove insecure software and add a changelog entry if necessary.

I say prune abandonware, and leave a release note.

In case someone needs it, they can use nixpkgs 21.11, IMO.

The package will be as broken, depending on an openssl that has been EOL since 2019, on any further release as it was in 21.11.

I am for removing it with a release note, too.

gador requested review from FRidh and jonringer as code owners January 12, 2022 13:59

github-actions bot added the 6.topic: python label Jan 12, 2022

ofborg bot added 8.has: clean-up 8.has: package (new) labels Jan 12, 2022

ofborg bot requested review from mkg20001, bhipple and SuperSandro2000 January 12, 2022 14:12

ofborg bot added 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 501-1000 labels Jan 12, 2022

SuperSandro2000 requested changes Jan 13, 2022

View reviewed changes

SuperSandro2000 reviewed Jan 13, 2022

View reviewed changes

pkgs/development/python-modules/eventlet/default.nix Outdated Show resolved Hide resolved

gador force-pushed the pgadmin4 branch 2 times, most recently from fb5f890 to 4955bfb Compare January 14, 2022 21:45

ofborg bot requested review from wmertens and domenkozar January 14, 2022 21:58

gador added a commit to gador/nixpkgs that referenced this pull request Jan 16, 2022

python3Packages.wtforms: 2.3.3 -> 3.0.1

0d2fa1e

needed for pgadmin4 init NixOS#154764

github-actions bot added 8.has: changelog 8.has: documentation 8.has: module (update) labels Feb 26, 2022

gador force-pushed the pgadmin4 branch from d565413 to ed27dea Compare February 26, 2022 10:28

github-actions bot removed 6.topic: python 6.topic: fetch 8.has: changelog 6.topic: nim Nim programing language 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: module (update) 8.has: documentation 6.topic: golang labels Feb 26, 2022

gador force-pushed the pgadmin4 branch from ed27dea to 29f1872 Compare February 26, 2022 12:04

pgadmin4: init at 6.3

0dda2d3

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>

ofborg bot removed request for jonringer, mkg20001, piegamesde and zowoq February 26, 2022 12:18

pgadmin3: move

69ec03d

moved pgadmin3 to pgadmin4 and renamed to 3.nix added an alias for pgadmin->pgadmin4 Signed-off-by: florian on nixos (Florian Brandes) <florian.brandes@posteo.de>

gador force-pushed the pgadmin4 branch from 29f1872 to 69ec03d Compare February 26, 2022 12:20

mkg20001 merged commit 3668790 into NixOS:master Feb 26, 2022

ajs124 mentioned this pull request Mar 14, 2022

Update pgadmin to v4 #33103

Closed

ajs124 reviewed Mar 14, 2022

View reviewed changes

mweinelt mentioned this pull request Mar 30, 2022

pgadmin3: drop #166487

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pgadmin4: init at 6.3 #154764

pgadmin4: init at 6.3 #154764

gador commented Jan 12, 2022 •

edited

SuperSandro2000 left a comment •

edited

SuperSandro2000 Jan 13, 2022

gador Jan 14, 2022

SuperSandro2000 Feb 15, 2022

gador Feb 23, 2022

gador commented Jan 14, 2022

mkg20001 commented Feb 26, 2022

gador commented Feb 26, 2022

mkg20001 commented Feb 26, 2022

gador commented Feb 26, 2022

gador commented Feb 26, 2022

nixos-discourse commented Mar 7, 2022

ajs124 Mar 14, 2022

mkg20001 Mar 15, 2022 •

edited

mweinelt Mar 15, 2022

mweinelt Mar 15, 2022

jonringer Mar 15, 2022

ajs124 Mar 15, 2022

SuperSandro2000 Mar 15, 2022

pgadmin4: init at 6.3 #154764

pgadmin4: init at 6.3 #154764

Conversation

gador commented Jan 12, 2022 • edited

Motivation for this change

Things done

SuperSandro2000 left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gador commented Jan 14, 2022

mkg20001 commented Feb 26, 2022

gador commented Feb 26, 2022

mkg20001 commented Feb 26, 2022

gador commented Feb 26, 2022

gador commented Feb 26, 2022

nixos-discourse commented Mar 7, 2022

Choose a reason for hiding this comment

mkg20001 Mar 15, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gador commented Jan 12, 2022 •

edited

SuperSandro2000 left a comment •

edited

mkg20001 Mar 15, 2022 •

edited