Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite: pass --enable-readline when interactive mode is enabled #15502

Merged
merged 1 commit into from
May 29, 2016
Merged

sqlite: pass --enable-readline when interactive mode is enabled #15502

merged 1 commit into from
May 29, 2016

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented May 16, 2016

Fix #14378

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @wkennington, @edolstra and @peti to be potential reviewers

@edolstra
Copy link
Member

This is strange because sqlite-interactive works fine on release-16.03 without --enable-readline (see e.g. http://hydra.nixos.org/build/35647716/log/raw). I'm guessing this is some closure-size fallout.

@edef1c
Copy link
Member Author

edef1c commented May 17, 2016

@edolstra closure-size fallout was my initial guess, but I'm not sure what precisely is going on here. Adding --enable-readline definitely did the trick, though.

@joachifm joachifm merged commit ca227d3 into NixOS:master May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants