Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove systemd shell aliases #15598

Merged
merged 1 commit into from May 23, 2016
Merged

Remove systemd shell aliases #15598

merged 1 commit into from May 23, 2016

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented May 21, 2016

These shell aliases are likely to clash with other commands. See #15596 for example, where status replaces a builtin command and causes lots of problems in the fish shell library.

@mention-bot
Copy link

@mention-bot mention-bot commented May 21, 2016

By analyzing the blame information on this pull request, we identified @edolstra, @rickynils and @bluescreen303 to be potential reviewers

@rnhmjoj rnhmjoj mentioned this pull request May 21, 2016
6 of 9 tasks complete
@jagajaga
Copy link
Member

@jagajaga jagajaga commented May 21, 2016

👍 👍 👍 👍 👍

@vcunat
Copy link
Member

@vcunat vcunat commented May 22, 2016

I think we should mention it in release notes.

@edolstra edolstra merged commit 0c5ebbd into NixOS:master May 23, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danbst
Copy link
Contributor

@danbst danbst commented May 23, 2016

Tragedy. I've discovered them recently and just started using... But they don't work over ssh, so not a big deal.

@vcunat
Copy link
Member

@vcunat vcunat commented May 23, 2016

@danbst: users should best define such non-standard aliases themselves. You can add them to your configuration.nix or ~/.profile...

@domenkozar
Copy link
Member

@domenkozar domenkozar commented May 23, 2016

Please, add such changes to release notes, otherwise 🍺

@vcunat
Copy link
Member

@vcunat vcunat commented May 23, 2016

Let me do it: 5eb0e13.

@rnhmjoj rnhmjoj deleted the rnhmjoj:systemd branch Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.