New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove systemd shell aliases #15598

Merged
merged 1 commit into from May 23, 2016

Conversation

Projects
None yet
8 participants
@rnhmjoj
Contributor

rnhmjoj commented May 21, 2016

These shell aliases are likely to clash with other commands. See #15596 for example, where status replaces a builtin command and causes lots of problems in the fish shell library.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 21, 2016

By analyzing the blame information on this pull request, we identified @edolstra, @rickynils and @bluescreen303 to be potential reviewers

mention-bot commented May 21, 2016

By analyzing the blame information on this pull request, we identified @edolstra, @rickynils and @bluescreen303 to be potential reviewers

@rnhmjoj rnhmjoj referenced this pull request May 21, 2016

Merged

fish: 2.2.0 -> 2.3.0 #15596

6 of 9 tasks complete
@jagajaga

This comment has been minimized.

Show comment
Hide comment
@jagajaga

jagajaga May 21, 2016

Member

👍 👍 👍 👍 👍

Member

jagajaga commented May 21, 2016

👍 👍 👍 👍 👍

@vcunat

This comment has been minimized.

Show comment
Hide comment
@vcunat

vcunat May 22, 2016

Member

I think we should mention it in release notes.

Member

vcunat commented May 22, 2016

I think we should mention it in release notes.

@edolstra edolstra merged commit 0c5ebbd into NixOS:master May 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danbst

This comment has been minimized.

Show comment
Hide comment
@danbst

danbst May 23, 2016

Contributor

Tragedy. I've discovered them recently and just started using... But they don't work over ssh, so not a big deal.

Contributor

danbst commented May 23, 2016

Tragedy. I've discovered them recently and just started using... But they don't work over ssh, so not a big deal.

@vcunat

This comment has been minimized.

Show comment
Hide comment
@vcunat

vcunat May 23, 2016

Member

@danbst: users should best define such non-standard aliases themselves. You can add them to your configuration.nix or ~/.profile...

Member

vcunat commented May 23, 2016

@danbst: users should best define such non-standard aliases themselves. You can add them to your configuration.nix or ~/.profile...

@domenkozar

This comment has been minimized.

Show comment
Hide comment
@domenkozar

domenkozar May 23, 2016

Member

Please, add such changes to release notes, otherwise 🍺

Member

domenkozar commented May 23, 2016

Please, add such changes to release notes, otherwise 🍺

@vcunat

This comment has been minimized.

Show comment
Hide comment
@vcunat

vcunat May 23, 2016

Member

Let me do it: 5eb0e13.

Member

vcunat commented May 23, 2016

Let me do it: 5eb0e13.

@rnhmjoj rnhmjoj deleted the rnhmjoj:systemd branch Aug 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment