Remove systemd shell aliases #15598

Merged
merged 1 commit into from May 23, 2016

Projects

None yet

8 participants

@rnhmjoj
Contributor
rnhmjoj commented May 21, 2016

These shell aliases are likely to clash with other commands. See #15596 for example, where status replaces a builtin command and causes lots of problems in the fish shell library.

@rnhmjoj rnhmjoj Remove systemd shell aliases 1d9651e
@mention-bot

By analyzing the blame information on this pull request, we identified @edolstra, @rickynils and @bluescreen303 to be potential reviewers

@rnhmjoj rnhmjoj referenced this pull request May 21, 2016
Merged

fish: 2.2.0 -> 2.3.0 #15596

6 of 9 tasks complete
@jagajaga
Member

👍 👍 👍 👍 👍

@vcunat
Member
vcunat commented May 22, 2016

I think we should mention it in release notes.

@edolstra edolstra merged commit 0c5ebbd into NixOS:master May 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danbst
Contributor
danbst commented May 23, 2016

Tragedy. I've discovered them recently and just started using... But they don't work over ssh, so not a big deal.

@vcunat
Member
vcunat commented May 23, 2016

@danbst: users should best define such non-standard aliases themselves. You can add them to your configuration.nix or ~/.profile...

@domenkozar
Member

Please, add such changes to release notes, otherwise 🍺

@vcunat
Member
vcunat commented May 23, 2016

Let me do it: 5eb0e13.

@rnhmjoj rnhmjoj deleted the rnhmjoj:systemd branch Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment