river: 0.1.0 -> 0.1.2 #156086
Merged
river: 0.1.0 -> 0.1.2 #156086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed the overrides for specific |
|
@ofborg build river |
|
Is this not a duplicate of #151900? |
|
It looks like it. I hadn't searched first. Sorry about that! Feel free to close this one if it would be better to use that one. |
Comment on lines
1
to
3
| { lib, stdenv, fetchFromGitHub, zig, wayland, pkg-config, scdoc, xwayland | ||
| , wayland-protocols, wlroots, libxkbcommon, pixman, udev, libevdev, libinput | ||
| , libX11, libGL }: |
There was a problem hiding this comment.
Please revert that. One line per input is the preferred format.
| See https://github.com/ifreund/river/blob/7ffa2f4b9e7abf7d152134f555373c2b63ccfc1d/river/main.zig#L56 | ||
| /* Builder patch install dir into river to get default config | ||
| When installFlags is removed, river becomes half broken. | ||
| See https://github.com/ifreund/river/blob/7ffa2f4b9e7abf7d152134f555373c2b63ccfc1d/river/main.zig#L56 |
There was a problem hiding this comment.
Suggested change
| See https://github.com/ifreund/river/blob/7ffa2f4b9e7abf7d152134f555373c2b63ccfc1d/river/main.zig#L56 | |
| See https://github.com/riverwm/river/blob/7ffa2f4b9e7abf7d152134f555373c2b63ccfc1d/river/main.zig#L56 |
There was a problem hiding this comment.
Good catch on this!
This was referenced Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upgrade river to the most recent version
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes