-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
river: 0.1.0 -> 0.1.2 #156086
river: 0.1.0 -> 0.1.2 #156086
Conversation
I removed the overrides for specific |
@ofborg build river |
Is this not a duplicate of #151900? |
It looks like it. I hadn't searched first. Sorry about that! Feel free to close this one if it would be better to use that one. |
{ lib, stdenv, fetchFromGitHub, zig, wayland, pkg-config, scdoc, xwayland | ||
, wayland-protocols, wlroots, libxkbcommon, pixman, udev, libevdev, libinput | ||
, libX11, libGL }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert that. One line per input is the preferred format.
See https://github.com/ifreund/river/blob/7ffa2f4b9e7abf7d152134f555373c2b63ccfc1d/river/main.zig#L56 | ||
/* Builder patch install dir into river to get default config | ||
When installFlags is removed, river becomes half broken. | ||
See https://github.com/ifreund/river/blob/7ffa2f4b9e7abf7d152134f555373c2b63ccfc1d/river/main.zig#L56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/ifreund/river/blob/7ffa2f4b9e7abf7d152134f555373c2b63ccfc1d/river/main.zig#L56 | |
See https://github.com/riverwm/river/blob/7ffa2f4b9e7abf7d152134f555373c2b63ccfc1d/river/main.zig#L56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on this!
Motivation for this change
Upgrade river to the most recent version
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes