Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remarshal: fix build #159074

Merged
merged 1 commit into from
Feb 10, 2022
Merged

remarshal: fix build #159074

merged 1 commit into from
Feb 10, 2022

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 10, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@zowoq zowoq mentioned this pull request Feb 10, 2022
Merged
jonringer
jonringer approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

https://github.com/NixOS/nixpkgs/pull/159074

4 packages built:
iosevka python310Packages.remarshal remarshal spacevim

Feel free to press merge :)

@zowoq
Copy link
Contributor Author

zowoq commented Feb 10, 2022

Tested a few random nixos tests, seems fine.

@zowoq zowoq marked this pull request as ready for review February 10, 2022 23:30
@zowoq zowoq requested a review from FRidh as a code owner February 10, 2022 23:30
@ofborg ofborg bot requested a review from offlinehacker February 10, 2022 23:36
@zowoq zowoq merged commit d00459d into NixOS:master Feb 10, 2022
@zowoq zowoq deleted the remarshal branch February 10, 2022 23:49
@zowoq zowoq mentioned this pull request Feb 11, 2022
Closed
13 tasks
@06kellyjac 06kellyjac mentioned this pull request Feb 11, 2022
Merged
13 tasks
@selene57 selene57 mentioned this pull request Feb 11, 2022
Merged
7 tasks
This was referenced Feb 12, 2022
Closed
Closed
cumber added a commit to cumber/nixos-configuration that referenced this pull request Feb 12, 2022
@cumber
manually update flake lock to get NixOS/nixpkgs#159074
c3f195b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @jonringer