Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME: 41 → 42 #160343

Merged
merged 256 commits into from
Mar 26, 2022
Merged

GNOME: 41 → 42 #160343

merged 256 commits into from
Mar 26, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Feb 16, 2022

https://discourse.gnome.org/t/gnome-42-released/9255
http://release.gnome.org/42
Introducing GNOME 42 - YouTube

https://github.com/NixOS/nixpkgs/projects/44

This time starting a bit early.


Main pain points:

Processes can only link against one version of the library (even transitively), or there will be symbol clashes!


cc @NixOS/gnome

https://hydra.nixos.org/jobset/nixpkgs/gnome

@jtojnar
Copy link
Member Author

jtojnar commented Feb 17, 2022

I went through the changelogs and added to-do tasks for https://github.com/NixOS/nixpkgs/projects/44
Notably, librest, gnome-desktop and libgnome-games, and possibly libgweather will probably require retaining the old version for now. gnome-bluetooth probably is not worth it since it is only used by blueberry cinnamon and they might drop it linuxmint/blueberry#123 (cc @mkg20001).

@mkg20001
Copy link
Member

mkg20001 commented Feb 17, 2022

@jtojnar Fedora seems to ship cinnamon with blueman instead of blueberry until the issue is resolved. This might be a solution, thought I'd be more keen on keeping the old gnome-bluetooth alive via the cinnamon scope instead, as otherwise once the situation is resolved it would make sense to switch back. So unless blueberry is going to be dropped the only reasonable solution would be keeping the old gnome-bluetooth, unless that's too much effort.

@jtojnar
Copy link
Member Author

jtojnar commented Feb 19, 2022

The VM builds now:

Screenshot from 2022-02-19 05-56-30

@mkg20001
Copy link
Member

@jtojnar I have a fix for blueberry: gnome...mkg20001:blueberry

@bobby285271
Copy link
Member

(#160343 (comment))

I find myself not that sure with what is changed in gnome-bluetooth. May I ask will bluetooth-sendto <file> still expected to work on non-GNOME DEs? If not it will likely also affect Pantheon. I actually check-picked the gnome-bluetooth, libadwaita and upower update here and rebuild my laptop, and the following window no longer shows for me when I try the contractor:

@jtojnar
Copy link
Member Author

jtojnar commented Feb 22, 2022

Yeah, that is on top of the todo list, just have not had time to investigate.

@jtojnar
Copy link
Member Author

jtojnar commented Feb 22, 2022

Looks like it is missing gtk_widget_show(dialog) here: https://gitlab.gnome.org/GNOME/gnome-bluetooth/-/blob/1123a3d41c3dd5b1b0a9abe731178d8202cf3fc4/sendto/main.c#L700

But then, when I select a file, it crashes.

@bobby285271
Copy link
Member

bobby285271 commented Feb 22, 2022

May I ask will bluetooth-sendto <file> still expected to work on non-GNOME DEs?

bluetooth-sendto program (gnome.gnome-bluetooth) does not seem to show file chooser when executed any more.

I just did a fresh installation of GNOME OS using latest gnome_os_installer_367892.iso, and I also cannot see filechooser / device selection widget there. Looks like the device selection widget is removed in this commit 😿

@jtojnar
Copy link
Member Author

jtojnar commented Feb 22, 2022

I already fixed the file selection locally and now I am working on porting sendto to GApplication. I will try to reintroduce the device selector after that. Edit: Got go-ahead from Bastien, you can follow the progress at https://gitlab.gnome.org/GNOME/gnome-bluetooth/-/merge_requests/120.

@vcunat
Copy link
Member

vcunat commented Mar 27, 2022

@jtojnar
Copy link
Member Author

jtojnar commented Mar 27, 2022

That sounds like a GLib bug, opened https://gitlab.gnome.org/GNOME/glib/-/issues/2625. Can someone on Darwin reproduce this with nix-build -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/6de161729c81dc98e844793cc9c8fda29d5ef62a.tar.gz darwin-atomic-test.nix with the following file?

let
  pkgs = import <nixpkgs> { };

  testSrc = pkgs.writeText "test.c" ''
    #include <glib.h>

    int main() {
        g_warning_once("attribute 'clip-path' given as CSS");

        return 0;
    }
  '';
in pkgs.runCommand "glib-collate-test" {
    buildInputs = with pkgs; [
      pkg-config
      glib
      clang
    ];
  } ''
    mkdir -p $out

    clang \
      $(pkg-config --cflags glib-2.0 gmodule-2.0) \
      $(pkg-config --libs glib-2.0 gmodule-2.0) \
      "${testSrc}" -o "$out/test"
  ''

@bobby285271
Copy link
Member

bobby285271 commented Mar 27, 2022

Tried to run that using GitHub actions, using macos-latest

@jtojnar
Copy link
Member Author

jtojnar commented Mar 27, 2022

Hmm, maybe it has something to do with some compiler flag.

@thefloweringash
Copy link
Member

I can reproduce on aarch64-darwin with clang++ instead of clang.

@jtojnar
Copy link
Member Author

jtojnar commented Mar 27, 2022

Nice, I can reproduce that on Linux too.

@vcunat
Copy link
Member

vcunat commented Mar 27, 2022

  • AlsonixosTests.gnome broke (and .gnome-xorg), blocking nixos-unstable channel. I can confirm locally on that commit. I haven't been able to retry on latest master, as many binaries are missing there so far (webkitgtk in particular).

@vcunat
Copy link
Member

vcunat commented Mar 27, 2022

I should've tried that before merging; retrospectively it's an obvious step.

@jtojnar
Copy link
Member Author

jtojnar commented Mar 27, 2022

🤦‍♀️ I ran the tests locally and noticed they were stuck but got sidetracked and forgot about that. Investigating now. Edit: Likely something to do with the fact that we no longer install GNOME Terminal.

@bobby285271
Copy link
Member

bobby285271 commented Mar 27, 2022

Maybe we should update gnomeTerminalCommand for gnome-console (and adjust other parts accordingly)?

@jtojnar
Copy link
Member Author

jtojnar commented Mar 27, 2022

Fixed in 8e251df as a stop gap, we should definitely switch to gnome-console.

@jtojnar
Copy link
Member Author

jtojnar commented Mar 27, 2022

Trying to address the Inkscape issue in 086c62d

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/12

@jtojnar
Copy link
Member Author

jtojnar commented Mar 28, 2022

More breakage:

  • missing background in dark mode (fix, and more)
  • GNOME Control Center: Clicking providers in Online Accounts panel does not do anything, “Failed to create foreign window for XID 0” in journal (XOrg session) https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1651
  • Geary unable to log in into GMail account “.goa-daemon-wra[147520]: secret_password_lookup_sync() returned NULL” logged in journal Looks like it was just expired credentials.

After pkill goa; pkill geary and starting Geary

Mar 28 18:10:59 theo dbus-daemon[142805]: [session uid=1000 pid=142805] Activating service name='org.gnome.OnlineAccounts' requested by ':1.326' (uid=1000 pid=156010 comm="/nix/store/fbzijxyh53ln7pyz07shva9hlffi0wmv-geary-" label="kernel")
Mar 28 18:10:59 theo .goa-daemon-wra[156023]: goa-daemon version 3.43.1 starting
Mar 28 18:10:59 theo dbus-daemon[142805]: [session uid=1000 pid=142805] Activating service name='org.gnome.Identity' requested by ':1.327' (uid=1000 pid=156023 comm="/nix/store/kmd8sbyf79c4a2p6jfgn1njbwiqjjk0q-gnome-" label="kernel")
Mar 28 18:10:59 theo dbus-daemon[142805]: [session uid=1000 pid=142805] Successfully activated service 'org.gnome.OnlineAccounts'
Mar 28 18:10:59 theo dbus-daemon[142805]: [session uid=1000 pid=142805] Successfully activated service 'org.gnome.Identity'
Mar 28 18:10:59 theo org.gnome.Geary[156010]: *[wrn] 18:10:59.0309 Gtk:Negative content height -1 (allocation 1, extents 1x1) while allocating gadget (node entry, owner GtkSearchEntry)
Mar 28 18:11:00 theo .goa-daemon-wra[156023]: secret_password_lookup_sync() returned NULL
Mar 28 18:11:00 theo .goa-daemon-wra[156023]: /org/gnome/OnlineAccounts/Accounts/account_1555078073_0: Setting AttentionNeeded to TRUE because EnsureCredentials() failed with: No credentials found in the keyring (goa-error-quark, 4)
Mar 28 18:11:01 theo .goa-daemon-wra[156023]: secret_password_lookup_sync() returned NULL
Mar 28 18:11:03 theo .goa-daemon-wra[156023]: secret_password_lookup_sync() returned NULL
Mar 28 18:11:03 theo .goa-daemon-wra[156023]: secret_password_lookup_sync() returned NULL

@fabianhjr
Copy link
Member

image

Can't reproduce second issue on staging-next and no difference on gnome specific packages ( git diff origin/master..HEAD -- pkgs/desktops/gnome/ is empty)

Probably fixed by a development library that is on staging-next.

@jtojnar
Copy link
Member Author

jtojnar commented Mar 28, 2022

Did you click one of the providers (e.g. Nextcloud)?

Another issue:

@fabianhjr
Copy link
Member

Did you click one of the providers (e.g. Nextcloud)?

Works, though don't have nextcloud to test.

image

@jtojnar
Copy link
Member Author

jtojnar commented Mar 28, 2022

Apparently, the issue only happens on Xorg.

@fabianhjr
Copy link
Member

fabianhjr commented Mar 28, 2022

I was/am on xorg, keybase-gui and other pre-electron-12 things do not work on wayland. UnU

EDIT:

echo $XDG_SESSION_TYPE           Mon 28 Mar 2022 01:03:06 PM CST
x11

@@ -547,7 +496,6 @@ in
programs.file-roller.enable = notExcluded pkgs.gnome.file-roller;
programs.geary.enable = notExcluded pkgs.gnome.geary;
programs.gnome-disks.enable = notExcluded pkgs.gnome.gnome-disk-utility;
programs.gnome-terminal.enable = notExcluded pkgs.gnome.gnome-terminal;
Copy link
Contributor

@andersk andersk Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the side effect of disabling programs.bash.vteIntegration and programs.zsh.vteIntegration, which should ideally still be enabled for gnome-console.

#166156

@risicle
Copy link
Contributor

risicle commented May 28, 2022

This also broke libical on darwin x86_64 through bumping to 3.0.14 , which includes some small timezeone-related changes that result in test failures: https://hydra.nixos.org/build/177029501

3.0.13 works.

@risicle
Copy link
Contributor

risicle commented May 28, 2022

Actually it seems like it might just be a flaky test, or perhaps it's due to impurities in the darwin environment but it's passing on my machine now 🤷

@jtojnar jtojnar mentioned this pull request Jul 23, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.